public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: RFA: fix PR python/11792
Date: Wed, 22 Sep 2010 20:57:00 -0000	[thread overview]
Message-ID: <m38w2t7e1s.fsf@fleche.redhat.com> (raw)
In-Reply-To: <83vd5xvaep.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Sep	2010 21:35:42 +0200")

Eli> Yes.  We are also supposed to humor the responsible maintainer when
Eli> she asks for some simple change as part of the review process.

Tom> That is no reason to ignore the agreed-upon rules.

Eli> It is to me.  The agreed-upon rules are a two-way street, you know.

I don't see how your behavior helps the situation.

Several alternatives to this approach were available to you.  For
example, you could have sent email saying that it was not a suggestion.
Or you could have said that in the first place.  Or, you could even have
asked me to revert my patch.

Tom> In this case I did not read your message as a request.  I saw it as a
Tom> conditional suggestion, which I chose not to take.

Eli> I don't see any difference between a suggestion and a request, when it
Eli> comes from the responsible maintainer.

You once told me that you never vetoed a patch, and that "Disagreement,
even a strong one, is not a veto unless you perceive it as such".  That
is how I have read all email from you from then on -- I try to make the
changes you like, but in the end, I rely on my own judgment.

Eli> I'm not going to fight with people to get my "suggestions" into the
Eli> manual against their explicitly expressed will (or lack thereof).

Sounds good.  Just post your patches, like all other contributors.

Tom

  reply	other threads:[~2010-09-22 19:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 20:13 Tom Tromey
2010-08-30 18:01 ` Tom Tromey
2010-08-30 18:24   ` Eli Zaretskii
2010-08-30 20:24     ` Tom Tromey
2010-08-30 20:43       ` Eli Zaretskii
2010-09-01 23:01         ` Tom Tromey
2010-09-02 10:32           ` Eli Zaretskii
2010-09-02 15:48             ` Tom Tromey
2010-09-02 18:40               ` Eli Zaretskii
2010-09-07 21:01                 ` Tom Tromey
2010-09-22 16:33                   ` Eli Zaretskii
2010-09-22 18:47                     ` Tom Tromey
2010-09-22 19:15                       ` Eli Zaretskii
2010-09-22 19:17                         ` Joel Brobecker
2010-09-22 19:19                           ` Eli Zaretskii
2010-09-22 19:26                             ` Tom Tromey
2010-09-22 19:59                               ` Eli Zaretskii
2010-09-22 20:57                                 ` Tom Tromey [this message]
2010-09-23 12:42                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38w2t7e1s.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).