From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix register selection in var-access.exp
Date: Wed, 14 Jun 2017 12:28:00 -0000 [thread overview]
Message-ID: <m3a85ag3ec.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <610f1674-ef5d-4218-fdba-fbad5c762971@redhat.com> (Pedro Alves's message of "Tue, 13 Jun 2017 22:24:27 +0100")
On Tue, Jun 13 2017, Pedro Alves wrote:
> On 06/13/2017 09:33 PM, Simon Marchi wrote:
>
>> However could you (or somebody else) explain this to me? The doc of
>> is_amd64_regs_target says:
>>
>> 2465 # Return 1 if target has x86_64 registers - either amd64 or x32.
>> 2466 # x32 target identifies as x86_64-*-linux*, therefore it cannot be
>> determined
>> 2467 # just from the target string.
>>
>> If x32 identifies as x86_64-something and that procedure should return
>> true when testing with x32 and x86_64/amd64, why can't we test the
>> target string for x86_64-*?
>
> Some vendors build --target i686-* toolchains, and then
> use -m64 to target the 64-bit multilib.
Hm, I wasn't aware of that. In addition, even on an x86_64-* target,
-m32 could be in effect. IMHO the comment is indeed misleading, but I'd
rather leave it to someone who actually knows all the various x86/amd64
targets and ABIs to fix it.
As this discussion is unrelated to the fix itself and the fix was
approved already, I pushed it now.
Thanks,
Andreas
prev parent reply other threads:[~2017-06-14 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 18:34 Andreas Arnez
2017-06-13 20:33 ` Simon Marchi
2017-06-13 21:24 ` Pedro Alves
2017-06-14 12:28 ` Andreas Arnez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a85ag3ec.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).