From: Doug Evans <xdje42@gmail.com>
To: Tim Wiederhake <tim.wiederhake@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com,
palves@redhat.com
Subject: Re: [PATCH v5 3/9] btrace: Use binary search to find instruction.
Date: Mon, 13 Feb 2017 03:58:00 -0000 [thread overview]
Message-ID: <m3a89qrbct.fsf@sspiff.org> (raw)
In-Reply-To: <1485527996-32506-4-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Fri, 27 Jan 2017 15:39:50 +0100")
Tim Wiederhake <tim.wiederhake@intel.com> writes:
> Currently, btrace_find_insn_by_number will iterate over all function call
> segments to find the one that contains the needed instruction. This linear
> search is too slow for the upcoming Python bindings that will use this
> function to access instructions. This patch introduces a vector in struct
> btrace_thread_info that holds pointers to all recorded function segments and
> allows to use binary search.
>
> The proper solution is to turn the underlying tree into a vector of objects
> and use indices for access. This requires more work. A patch set is
> currently being worked on and will be published later.
>
> 2017-01-27 Tim Wiederhake <tim.wiederhake@intel.com>
>
> gdb/ChangeLog:
> * btrace.c (btrace_fetch): Copy function call segments pointer
> into a vector.
> (btrace_clear): Clear the vector.
> (btrace_find_insn_by_number): Use binary search to find the correct
> function call segment.
> * btrace.h (brace_fun_p): New typedef.
> (struct btrace_thread_info) <functions>: New field.
LGTM
next prev parent reply other threads:[~2017-02-13 3:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 14:40 [PATCH v5 0/9] Python bindings for btrace recordings Tim Wiederhake
2017-01-27 14:40 ` [PATCH v5 4/9] Add record_start and record_stop functions Tim Wiederhake
2017-02-13 3:58 ` Doug Evans
2017-01-27 14:40 ` [PATCH v5 6/9] python: Create Python bindings for record history Tim Wiederhake
2017-02-13 3:58 ` Doug Evans
2017-01-27 14:40 ` [PATCH v5 3/9] btrace: Use binary search to find instruction Tim Wiederhake
2017-02-13 3:58 ` Doug Evans [this message]
2017-01-27 14:40 ` [PATCH v5 8/9] python: Add tests for record Python bindings Tim Wiederhake
2017-02-13 3:51 ` Doug Evans
2017-02-13 12:39 ` Wiederhake, Tim
2017-01-27 14:40 ` [PATCH v5 9/9] Add documentation for new " Tim Wiederhake
2017-01-27 14:40 ` [PATCH v5 5/9] Add method to query current recording method to target_ops Tim Wiederhake
2017-02-13 3:58 ` Doug Evans
2017-01-27 14:41 ` [PATCH v5 1/9] btrace: Count gaps as one instruction explicitly Tim Wiederhake
2017-02-13 3:57 ` Doug Evans
2017-01-27 14:41 ` [PATCH v5 7/9] python: Implement btrace Python bindings for record history Tim Wiederhake
2017-02-13 3:46 ` Doug Evans
2017-02-13 12:38 ` Wiederhake, Tim
2017-01-27 14:41 ` [PATCH v5 2/9] btrace: Export btrace_decode_error function Tim Wiederhake
2017-02-13 3:57 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a89qrbct.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).