[obv] spu-tdep.c: Compilation error regression

[obv] spu-tdep.c: Compilation error regression

[Jan Kratochvil]

Hi,

recent check-in
http://sourceware.org/ml/gdb-cvs/2010-11/msg00051.html
7d5a91474a0cdb796031ddc25aa0d107be6eb39d
2010-11-11  Phil Muldoon  <pmuldoon@redhat.com>
[...]
        * breakpoint.c
        (create_breakpoint_sal): Take a new parameter called internal.
        Call set_breakpoint_number with internal parameter.  Do not
        mention internal breakpoints.  All callers updated.
        (create_breakpoint): Ditto.
[...]

broke --enable-targets=all compilation incl. regression testing:

spu-tdep.c: In function ‘spu_catch_start’:
spu-tdep.c:1899:27: error: expected statement before ‘)’ token

Checked in as obvious.


Regards,
Jan


http://sourceware.org/ml/gdb-cvs/2010-11/msg00055.html

--- src/gdb/ChangeLog	2010/11/11 14:11:49	1.12305
+++ src/gdb/ChangeLog	2010/11/12 12:38:38	1.12306
@@ -1,3 +1,7 @@
+2010-11-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* spu-tdep.c (spu_catch_start): Fix compilation error typo.
+
 2010-11-11  Phil Muldoon  <pmuldoon@redhat.com>
 
 	* python/py-breakpoint.c (BPPY_REQUIRE_VALID): Check if bp is
--- src/gdb/spu-tdep.c	2010/11/11 14:11:52	1.63
+++ src/gdb/spu-tdep.c	2010/11/12 12:38:39	1.64
@@ -1896,7 +1896,7 @@
 		     0 /* ignore_count */,
 		     AUTO_BOOLEAN_FALSE /* pending_break_support */,
 		     NULL /* ops */, 0 /* from_tty */, 1 /* enabled */,
-		     0 /* internal  */););
+		     0 /* internal  */);
 }
 
 

Re: [obv] spu-tdep.c: Compilation error regression

[Phil Muldoon]

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> Hi,
>
> recent check-in
> http://sourceware.org/ml/gdb-cvs/2010-11/msg00051.html
> 7d5a91474a0cdb796031ddc25aa0d107be6eb39d
> 2010-11-11  Phil Muldoon  <pmuldoon@redhat.com>
> [...]
>         * breakpoint.c
>         (create_breakpoint_sal): Take a new parameter called internal.
>         Call set_breakpoint_number with internal parameter.  Do not
>         mention internal breakpoints.  All callers updated.
>         (create_breakpoint): Ditto.
> [...]
>
> broke --enable-targets=all compilation incl. regression testing:
>
> spu-tdep.c: In function ‘spu_catch_start’:
> spu-tdep.c:1899:27: error: expected statement before ‘)’ token
>
> Checked in as obvious.


Ugh, sorry for not catching that. 

Thanks

Phil