From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30943 invoked by alias); 26 Oct 2010 13:44:27 -0000 Received: (qmail 30927 invoked by uid 22791); 26 Oct 2010 13:44:26 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 13:44:11 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9QDi8gH017993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Oct 2010 09:44:08 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9QDi73O015131; Tue, 26 Oct 2010 09:44:08 -0400 Received: from parfait.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9QDi6Rp003942; Tue, 26 Oct 2010 09:44:07 -0400 From: Tom Tromey To: Ken Werner Cc: gdb-patches@sourceware.org Subject: Re: [patch] initial OpenCL C language support References: <201010221920.30046.ken@linux.vnet.ibm.com> <201010261505.07587.ken@linux.vnet.ibm.com> Date: Tue, 26 Oct 2010 13:44:00 -0000 In-Reply-To: <201010261505.07587.ken@linux.vnet.ibm.com> (Ken Werner's message of "Tue, 26 Oct 2010 15:05:07 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00366.txt.bz2 >>>>> "Ken" == Ken Werner writes: Ken> My understanding is that the only additional functionality of Ken> evaluate_subexp_c is to provide wide character support which is not Ken> available in OpenCL C. Of course calling evaluate_subexp_c won't Ken> hurt since evaluate_subexp_standard gets called in most cases but I Ken> don't see where the OpenCL support could benefit from doing so. Do Ken> you have an example? c-exp.y emits a different format for OP_STRING than other parsers. It uses write_exp_string_vector, not write_exp_string. So I misspoke earlier; I think no string constant will work properly without this change. Tom