From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3897 invoked by alias); 26 Apr 2010 18:51:03 -0000 Received: (qmail 3879 invoked by uid 22791); 26 Apr 2010 18:50:58 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 18:50:53 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QIoUvn011829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Apr 2010 14:50:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3QIoUer029884; Mon, 26 Apr 2010 14:50:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3QIoTuK011535; Mon, 26 Apr 2010 14:50:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 07C4637820A; Mon, 26 Apr 2010 12:50:29 -0600 (MDT) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [vxworks 02/14] New command_post observer. References: <1272210447-13895-1-git-send-email-brobecker@adacore.com> <1272210447-13895-3-git-send-email-brobecker@adacore.com> Reply-To: tromey@redhat.com Date: Mon, 26 Apr 2010 18:51:00 -0000 In-Reply-To: <1272210447-13895-3-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sun, 25 Apr 2010 11:47:15 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00888.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> The problem is that we cannot just print a message everytime the PD Joel> gets switched, because many commands result in a temporary switch of Joel> partition. Joel> The way we solved this is by remembering the PD ID before we issued Joel> the last command. At the end of a command execution, if the PD ID Joel> changed, then we write a notification... Joel> This patch introduces an observer (command_post) that gets triggered Joel> at the end of a command execution... There are a lot of calls to execute_command that occur in batch-like places. For example, this is called from Python, I think it is called from "commands" scripts and "define" scripts, etc. So if your goal is to have it just emit info at some stopping point, it seems to me that it would be better to have an observer just before a prompt is emitted. I didn't read every patch in detail, so I didn't see where this is used. Maybe the above doesn't matter. Tom