From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] babeltrace compilation regression [Re: [PATCH] Avoid non-C++-enabled babeltrace versions]
Date: Mon, 04 Jul 2016 08:39:00 -0000 [thread overview]
Message-ID: <m3bn2dvltd.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <20160703154333.GA9193@host1.jankratochvil.net> (Jan Kratochvil's message of "Sun, 3 Jul 2016 17:43:33 +0200")
On Sun, Jul 03 2016, Jan Kratochvil wrote:
> On Wed, 27 Apr 2016 16:24:23 +0200, Andreas Arnez wrote:
>> Thanks, pushed after adjusting the commit message.
>
> Since:
> commit 2d681be471cf8aff8f296cb7713c39e9aa4fc2bb
> Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Wed Apr 27 15:52:16 2016 +0200
> Avoid non-C++-enabled babeltrace versions
> tested with:
> libbabeltrace-devel-1.2.4-4.fc24.x86_64
> libbabeltrace-devel-1.4.0-2.fc25.x86_64
> it can no longer build due to:
> configure:16435: gcc -o conftest -m64 -g3 -pipe -Wall -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -fno-diagnostics-show-caret -Werror -static-libstdc++ -static-libgcc conftest.c -ldl -ldl -lncurses -lm -ldl -lbabeltrace -lbabeltrace-ctf >&5
> conftest.c: In function 'main':
> conftest.c:208:7: error: 'pos' is a pointer; did you mean to use '->'?
>
> Have you tested that your line
> pos.type = BT_SEEK_BEGIN;
> with some libbabeltrace version or was that just a typo?
Phew, curious... this sure looks like a typo. IIRC, I've tested that
GDB *builds*, but probably forgot to verify that the babeltrace
configure check actually succeeds. Sorry about that.
--
Andreas
next prev parent reply other threads:[~2016-07-04 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 11:16 [PATCH] Avoid non-C++-enabled babeltrace versions Andreas Arnez
2016-04-27 12:02 ` Pedro Alves
2016-04-27 14:24 ` Andreas Arnez
2016-07-03 15:43 ` [patch] babeltrace compilation regression [Re: [PATCH] Avoid non-C++-enabled babeltrace versions] Jan Kratochvil
2016-07-04 8:39 ` Andreas Arnez [this message]
2016-07-05 8:50 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bn2dvltd.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).