From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93178 invoked by alias); 10 Aug 2015 19:54:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92355 invoked by uid 89); 10 Aug 2015 19:54:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 10 Aug 2015 19:54:57 +0000 Received: by pacgr6 with SMTP id gr6so33453785pac.2 for ; Mon, 10 Aug 2015 12:54:55 -0700 (PDT) X-Received: by 10.66.160.1 with SMTP id xg1mr47781842pab.27.1439236495762; Mon, 10 Aug 2015 12:54:55 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id fm3sm20397713pdb.49.2015.08.10.12.54.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Aug 2015 12:54:55 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v6 0/9] Series short description References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> Date: Mon, 10 Aug 2015 19:54:00 -0000 In-Reply-To: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Wed, 05 Aug 2015 16:28:54 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00229.txt.bz2 Keith Seitz writes: > This series is the latest revision of the locations API redesign > which introduces the concept of explicit locations (in addition to > address, linespec, and probe locations). > > Several of the patches have already been approved, but I am reposting > the entire (rebased) series. > > --- > > Keith Seitz (9): > Explicit locations: rename "address string"/"addr_string" to "location" > Explicit locations: introduce new struct event_location-based API > Explicit locations: use new location API > Explicit locations: introduce address locations > Explicit locations: introduce probe locations > Explicit locations: introduce explicit locations > Explicit locations: add UI features for CLI > Explicit locations: MI support for explicit locations > Explicit locations: documentation updates Except for the nits it all LGTM. [IIUC convention requires re-emailing the patch that was ultimately checked in if it changed. In this case I'd be totally ok with letting it slide, but whatever.] If I could give you a "peer bonus" I would! Thanks so much for seeing it through!