From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16380 invoked by alias); 16 Jan 2012 19:29:11 -0000 Received: (qmail 16331 invoked by uid 22791); 16 Jan 2012 19:29:10 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 19:28:55 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0GJSlkZ028357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jan 2012 14:28:55 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0GIDVFK013434; Mon, 16 Jan 2012 13:13:31 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0GIDUJK029989; Mon, 16 Jan 2012 13:13:30 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [RFC 0/8] Beginning to remove globals from parser-defs.h References: Date: Mon, 16 Jan 2012 19:29:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Sun, 15 Jan 2012 16:48:52 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00566.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> I have been working on this during my weekends, and I would like Sergio> to know what you guys think about this set of patches. I sent a comment on the c-exp.y patch, but really the same comment applies to all of them. Other than that, I think it is a good cleanup. Sergio> There are still some (lots of?) other global variables there, Sergio> which I didn't touch yet. Maybe some day I will have Sergio> time/patience for that... Yeah, it would be good if you could. Half-done transitions are sort of a pain; gdb has plenty of these already. Tom