* [PATCH] Add missing trace state variable cleanup
@ 2010-04-16 18:37 Stan Shebs
2010-04-20 18:03 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Stan Shebs @ 2010-04-16 18:37 UTC (permalink / raw)
To: gdb-patches
As a reminder not to be careless about cleanups, our customer found an
easy way to crash GDB due to this one's absence. Committed to trunk.
Stan
2010-04-16 Stan Shebs <stan@codesourcery.com>
* tracepoint.c (trace_variable_command): Run a cleanup.
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.179
diff -p -r1.179 tracepoint.c
*** tracepoint.c 16 Apr 2010 01:12:07 -0000 1.179
--- tracepoint.c 16 Apr 2010 18:21:06 -0000
*************** trace_variable_command (char *args, int
*** 365,370 ****
--- 365,371 ----
tsv->initial_value = initval;
printf_filtered (_("Trace state variable $%s now has initial
value %s.\n"),
tsv->name, plongest (tsv->initial_value));
+ do_cleanups (old_chain);
return;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Add missing trace state variable cleanup
2010-04-16 18:37 [PATCH] Add missing trace state variable cleanup Stan Shebs
@ 2010-04-20 18:03 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2010-04-20 18:03 UTC (permalink / raw)
To: Stan Shebs; +Cc: gdb-patches
>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
Stan> As a reminder not to be careless about cleanups, our customer found an
Stan> easy way to crash GDB due to this one's absence. Committed to trunk.
FWIW, cleanup checking is my #1 wish for static analysis of gdb.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-20 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-16 18:37 [PATCH] Add missing trace state variable cleanup Stan Shebs
2010-04-20 18:03 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).