From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119733 invoked by alias); 23 Aug 2015 04:19:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119721 invoked by uid 89); 23 Aug 2015 04:19:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 04:19:02 +0000 Received: by padfo6 with SMTP id fo6so35136419pad.1 for ; Sat, 22 Aug 2015 21:19:00 -0700 (PDT) X-Received: by 10.66.219.39 with SMTP id pl7mr32702059pac.148.1440303540689; Sat, 22 Aug 2015 21:19:00 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id ll8sm8328242pab.39.2015.08.22.21.18.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Aug 2015 21:19:00 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 13/19] Implement completion limiting for complete_on_enum. References: <20150806191404.32159.50755.stgit@valrhona.uglyboxes.com> <20150806191920.32159.96756.stgit@valrhona.uglyboxes.com> Date: Sun, 23 Aug 2015 04:19:00 -0000 In-Reply-To: <20150806191920.32159.96756.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 06 Aug 2015 12:19:34 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00652.txt.bz2 Keith Seitz writes: > Differences in this revision: > > 1. Remove partial copy code from complete_on_enum > > --- > > This is another patch to push along the conversion of location_completer > toward using add_completion. In this patch, complete_on_enum is > converted. This function is also used by several other commands, such as > integer_unlimited_completer, handle_completer, cp_abi_completer, etc. > > gdb/ChangeLog > > * cli/cli-decode.c (complete_on_enum): Use add_completion. > > gdb/testsuite/ChangeLog > > * gdb.base/completion.exp: Add tests for complete_on_enum > completion limiting using "handle signal". LGTM