From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75698-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9674 invoked by alias); 22 Sep 2010 19:42:55 -0000
Received: (qmail 9664 invoked by uid 22791); 22 Sep 2010 19:42:55 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 19:42:48 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8MJglgA018329	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 22 Sep 2010 15:42:47 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8MJgkdp000400;	Wed, 22 Sep 2010 15:42:47 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8MJgkth028977;	Wed, 22 Sep 2010 15:42:46 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 10EFC378875; Wed, 22 Sep 2010 13:42:46 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Code cleanup: objfile->name is never NULL
References: <20100922094323.GA20792@host1.dyn.jankratochvil.net>
Date: Wed, 22 Sep 2010 20:40:00 -0000
In-Reply-To: <20100922094323.GA20792@host1.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Wed, 22 Sep 2010 11:43:23 +0200")
Message-ID: <m3d3s57efe.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-09/txt/msg00393.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> there is some FUD in GDB code whether objfile->name can be NULL.  I
Jan> haven't found a way it could be.  Also a lot of GDB code already
Jan> assumes it is not NULL.

I agree with this patch.

Jan> -  if (!objfile->name)
Jan> -    return;
 
Jan>    load_auto_scripts_for_objfile (objfile);

This part made me realize that we should probably have some kind of "is
a file" flag on the objfile, to avoid trying to load files relative to a
phony name like "<<anonymous objfile>>".

Tom