From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12809 invoked by alias); 16 Sep 2010 18:30:52 -0000 Received: (qmail 12800 invoked by uid 22791); 16 Sep 2010 18:30:52 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Sep 2010 18:30:43 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8GIUcxl011578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Sep 2010 14:30:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8GIUbte010248; Thu, 16 Sep 2010 14:30:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8GIUXHx009530; Thu, 16 Sep 2010 14:30:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A2F6F3784BE; Thu, 16 Sep 2010 12:30:32 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: Your INTERMEDIATE_ENCODING patch for Solaris References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <20100817184407.GC3599@adacore.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <44796.6229789474$1283326243@news.gmane.org> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> <002301cb54bc$661506f0$323f14d0$@muller@ics-cnrs.unistra.fr> <001f01cb5574$78252a60$686f7f20$@muller@ics-cnrs.unistra.fr> Date: Thu, 16 Sep 2010 20:22:00 -0000 In-Reply-To: <001f01cb5574$78252a60$686f7f20$@muller@ics-cnrs.unistra.fr> (Pierre Muller's message of "Thu, 16 Sep 2010 09:55:02 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00305.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Tom> Great. Here is what I am checking in. Pierre> Nice, but I was wondering if the Pierre> check of libiconv version is still needed. Pierre> Wasn't it suggested by me? According to the comment, versions of libiconv before 0x10D do not support "wchar_t" as an argument to iconv_open. I think you discovered this, but it is hard to remember. Pierre> I think that checking for the existence of Pierre> _LIBICONV_VERSION macro should be enough, Pierre> unless you are really sure that older versions Pierre> do not work. Pierre> On systems that have an older GNU libiconv Pierre> version installed, this might disable the use of GNU libiconv Pierre> without a good reason. I think it is better to fail safe: If this code is disabled, the user gets reduced functionality. If this code is erroneously enabled, users can't print strings at all. Tom