From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Add solib_address and decode_line Python functionality
Date: Fri, 06 Aug 2010 22:39:00 -0000 [thread overview]
Message-ID: <m3d3tvqsca.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C5C1418.7030607@redhat.com> (Phil Muldoon's message of "Fri, 06 Aug 2010 14:54:32 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> I looked at the documentation and PY_LONG_LONG is only available on
Phil> some platforms (namely, 64 bit platforms). I used unsigned long, and
Phil> 'k' instead.
I think PY_LONG_LONG should be available in other situations too -- in
particular if the compiler supports "long long", which GCC does.
It is important to use PY_LONG_LONG if it is available. E.g., consider
if gdb is hosted on a 32-bit machine but debugging a 64-bit executable.
In this case an address will be 64 bits.
So, could you make this conditional?
The rest looks good to me.
Tom
next prev parent reply other threads:[~2010-08-06 22:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 15:43 Phil Muldoon
2010-07-27 16:26 ` Joel Brobecker
2010-07-28 11:35 ` Phil Muldoon
2010-07-28 17:39 ` Joel Brobecker
2010-07-28 17:48 ` Eli Zaretskii
2010-07-29 20:39 ` Tom Tromey
2010-08-06 13:55 ` Phil Muldoon
2010-08-06 15:36 ` Eli Zaretskii
2010-08-06 22:39 ` Tom Tromey [this message]
2010-08-10 11:17 ` Phil Muldoon
2010-08-10 17:07 ` Eli Zaretskii
2010-08-10 18:24 ` Tom Tromey
2010-08-11 13:16 ` Phil Muldoon
2010-08-13 14:07 ` Ken Werner
2010-08-13 14:14 ` Phil Muldoon
2010-08-13 15:48 ` Tom Tromey
2010-08-13 16:22 ` Ken Werner
2010-08-18 23:55 ` Pedro Alves
2010-08-19 16:32 ` Tom Tromey
2010-08-19 17:04 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3tvqsca.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).