From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11696 invoked by alias); 6 Aug 2010 22:39:21 -0000 Received: (qmail 11684 invoked by uid 22791); 6 Aug 2010 22:39:21 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Aug 2010 22:39:16 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o76Md3vG023241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Aug 2010 18:39:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o76Md2Dc000583; Fri, 6 Aug 2010 18:39:02 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o76Md1ED012689; Fri, 6 Aug 2010 18:39:02 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 91C2C3782ED; Fri, 6 Aug 2010 16:39:01 -0600 (MDT) From: Tom Tromey To: Phil Muldoon Cc: Joel Brobecker , gdb-patches ml Subject: Re: [patch] Add solib_address and decode_line Python functionality References: <4C44728D.4040408@redhat.com> <20100727162545.GF13267@adacore.com> <4C5015E2.4000205@redhat.com> <4C5C1418.7030607@redhat.com> Date: Fri, 06 Aug 2010 22:39:00 -0000 In-Reply-To: <4C5C1418.7030607@redhat.com> (Phil Muldoon's message of "Fri, 06 Aug 2010 14:54:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00091.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> I looked at the documentation and PY_LONG_LONG is only available on Phil> some platforms (namely, 64 bit platforms). I used unsigned long, and Phil> 'k' instead. I think PY_LONG_LONG should be available in other situations too -- in particular if the compiler supports "long long", which GCC does. It is important to use PY_LONG_LONG if it is available. E.g., consider if gdb is hosted on a 32-bit machine but debugging a 64-bit executable. In this case an address will be 64 bits. So, could you make this conditional? The rest looks good to me. Tom