From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28704 invoked by alias); 2 Jul 2010 21:47:51 -0000 Received: (qmail 28696 invoked by uid 22791); 2 Jul 2010 21:47:50 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Jul 2010 21:47:45 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o62LlMX0009177 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Jul 2010 17:47:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o62LlL0e027797; Fri, 2 Jul 2010 17:47:21 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o62LlK1c017690; Fri, 2 Jul 2010 17:47:20 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id ABAD2378196; Fri, 2 Jul 2010 15:47:18 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: "'Doug Evans'" , "'Pedro Alves'" , Subject: Re: [RFA]dwarf reader: Avoid complaint on const type References: <41597.7287375883$1274454923@news.gmane.org> <201006161708.41089.pedro@codesourcery.com> <3752333521215815628@unknownmsgid> <29342.6726283089$1277816998@news.gmane.org> Date: Fri, 02 Jul 2010 21:47:00 -0000 In-Reply-To: <29342.6726283089$1277816998@news.gmane.org> (Pierre Muller's message of "Tue, 29 Jun 2010 15:09:41 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00057.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> --- src/gdb/dwarf2read.c 28 Jun 2010 22:03:31 -0000 1.406 Pierre> +++ src/gdb/dwarf2read.c 29 Jun 2010 12:31:55 -0000 Pierre> @@ -3220,12 +3220,15 @@ process_die (struct die_info *die, struc Pierre> case DW_TAG_base_type: Pierre> case DW_TAG_subrange_type: Pierre> case DW_TAG_typedef: Pierre> - case DW_TAG_const_type: Pierre> - case DW_TAG_volatile_type: Pierre> /* Add a typedef symbol for the type definition, if it has a Pierre> DW_AT_name. */ Pierre> new_symbol (die, read_type_die (die, cu), cu); Pierre> break; Pierre> + /* Type modifiers should be accepted without creating a new type Pierre> name. */ Pierre> + case DW_TAG_const_type: Pierre> + case DW_TAG_volatile_type: Pierre> + read_type_die (die, cu); Pierre> + break; Why here and not a little earlier, with this case? /* These dies have a type, but processing them does not create a symbol or recurse to process the children. Therefore we can read them on-demand through read_type_die. */ case DW_TAG_subroutine_type: case DW_TAG_set_type: case DW_TAG_array_type: case DW_TAG_pointer_type: case DW_TAG_ptr_to_member_type: case DW_TAG_reference_type: case DW_TAG_string_type: break; Pierre> case DW_TAG_base_type: Pierre> - case DW_TAG_subrange_type: Pierre> - case DW_TAG_const_type: Pierre> - case DW_TAG_volatile_type: Pierre> + case DW_TAG_subrange_type: Pierre> SYMBOL_CLASS (sym) = LOC_TYPEDEF; Pierre> SYMBOL_DOMAIN (sym) = VAR_DOMAIN; Pierre> add_symbol_to_list (sym, cu->list_in_scope); Why remove DW_TAG_subrange_type here? Tom