From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: next/finish/etc -vs- exceptions
Date: Wed, 24 Nov 2010 18:24:00 -0000 [thread overview]
Message-ID: <m3eiaazikn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101124175316.GA2634@adacore.com> (Joel Brobecker's message of "Wed, 24 Nov 2010 09:53:16 -0800")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> We are all so busy these days... When that happens, I suggest we
Joel> avoid being too conservative on the HEAD, especially this far
Joel> before the next branch creation. If you've already had Pedro's
Joel> comments and you think you addressed them, how about going ahead?
Joel> We can always revert later on...
I will consider it. If I do it will not be until next week at the
earliest.
Tom> + case bp_exception_master:
Tom> + /* These should never be enabled. */
Tom> + printf_filtered (_("Exception Master Breakpoint: gdb should not stop!\n"));
Tom> + result = PRINT_NOTHING;
Tom> + break;
Joel> I understand that an assert or internal-error would be unnecessarily
Joel> catastrophic for the user, but how about a warning instead? (just a
Joel> thought - this is really cosmetic)
I just copied what the other cases in that function do.
Maybe they should be changed -- I am not sure.
If so, that should be a separate patch.
Tom> + /* Used for BPSTAT_WHAT_SET_LONGJMP_RESUME. True if we are
Tom> + handling a longjmp, false if we are handling an exception. */
Tom> + int is_longjmp;
Joel> This component is also used with BPSTAT_WHAT_CLEAR_LONGJMP_RESUME.
Thanks, I updated my branch.
Tom
next prev parent reply other threads:[~2010-11-24 18:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 1:37 Tom Tromey
2010-11-24 17:53 ` Joel Brobecker
2010-11-24 18:24 ` Tom Tromey [this message]
2010-11-25 7:59 ` Jan Kratochvil
2010-11-27 17:25 ` Doug Evans
2010-11-28 8:29 ` Joel Brobecker
2010-11-30 16:43 ` Tom Tromey
2010-11-30 17:02 ` Jan Kratochvil
2010-11-30 17:15 ` Phil Muldoon
2010-11-30 20:15 ` Tom Tromey
2010-12-01 13:42 ` Jan Kratochvil
2010-12-01 21:40 ` Tom Tromey
2010-11-30 18:23 ` Tom Tromey
2010-11-30 18:55 ` Tom Tromey
2010-12-02 15:32 ` Tom Tromey
2010-12-09 16:37 ` Tom Tromey
2010-12-10 4:52 ` Jan Kratochvil
2010-12-10 20:07 ` Tom Tromey
2010-12-11 5:27 ` Jan Kratochvil
2010-12-15 21:18 ` Tom Tromey
[not found] <m37hzzzgk7.fsf@fleche.redhat.com>
[not found] ` <20090610161204.GB25703@adacore.com>
[not found] ` <m3hbyoghit.fsf@fleche.redhat.com>
[not found] ` <200906101806.31977.pedro@codesourcery.com>
[not found] ` <20090610171328.GA32661@caradoc.them.org>
2010-11-25 4:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eiaazikn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).