Re: [patch 1/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache]

[Tom Tromey <tromey@redhat.com>]

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> +/* Forwarding function for memcmp.  */
Sami> +//bcache_memcmp ()

Remove.

Sami> +bcache_xmalloc (unsigned long (*hash_function)(const void*, int length),
Sami> +                int (*compare_function)(const void*, const void*, int length))

Space in "void *".

Sami> +extern struct bcache *bcache_xmalloc (
Sami> +    unsigned long (*hash_function)(const void*, int length),
Sami> +    int (*compare_function)(const void*, const void*, int length));

Likewise.

Sami>    /* psymbol is static so that there will be no uninitialized gaps in the
Sami>       structure which might contain random data, causing cache misses in
Sami>       bcache. */
Sami> -  static struct partial_symbol psymbol;
Sami> +  struct partial_symbol psymbol;

Remove the comment here.  It is no longer valid.

Sami>    /* However, we must ensure that the entire 'value' field has been
Sami>       zeroed before assigning to it, because an assignment may not

We probably don't need this comment or the memset any more.

Tom