FYI: make python install directory

FYI: make python install directory

[Tom Tromey]

I'm checking this in on the trunk and the 7.2 branch.

PR 11900 says that gdb's breaks help with Python 2.4.
This happens because the gdb module's __path__ points to a directory
which does not exist.

This patch fixes the problem by arranging to make the appropriate
directory at install time.

Joel, I'm afraid your patches in this area will need a small update.
Or you can just back this out when those go in -- it doesn't matter at
all to me.  I went with this very minimal patch just because it seems
important to fix for 7.2.

Tom

2010-08-18  Tom Tromey  <tromey@redhat.com>

	PR python/11900:
	* configure: Rebuild.
	* configure.ac: Add install-python to CONFIG_INSTALL.
	* Makefile.in (install-python): New.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1127.2.1
diff -u -r1.1127.2.1 Makefile.in
--- Makefile.in	28 Jul 2010 18:32:47 -0000	1.1127.2.1
+++ Makefile.in	18 Aug 2010 22:52:22 -0000
@@ -1037,6 +1037,8 @@
 		$(INSTALL_DATA) $(srcdir)/gdb.1 \
 			$(DESTDIR)$(man1dir)/$$transformed_name.1
 
+install-python:
+	$(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb
 
 uninstall: force $(CONFIG_UNINSTALL)
 	transformed_name=`t='$(program_transform_name)'; \
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.125.2.2
diff -u -r1.125.2.2 configure.ac
--- configure.ac	30 Jul 2010 16:02:16 -0000	1.125.2.2
+++ configure.ac	18 Aug 2010 22:52:23 -0000
@@ -832,6 +832,7 @@
   CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_PYTHON_OBS)"
   CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_PYTHON_DEPS)"
   CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_PYTHON_SRCS)"
+  CONFIG_INSTALL="$CONFIG_INSTALL install-python"
   ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_PYTHON_CFLAGS)"
 
   # Flags needed to compile Python code (taken from python-config --cflags).

Re: FYI: make python install directory

[Michael Snyder]

Tom Tromey wrote:
> I'm checking this in on the trunk and the 7.2 branch.
> 
> PR 11900 says that gdb's breaks help with Python 2.4.
> This happens because the gdb module's __path__ points to a directory
> which does not exist.
> 
> This patch fixes the problem by arranging to make the appropriate
> directory at install time.
> 
> Joel, I'm afraid your patches in this area will need a small update.
> Or you can just back this out when those go in -- it doesn't matter at
> all to me.  I went with this very minimal patch just because it seems
> important to fix for 7.2.

This seems to generate a new build error for me:

     mkdir cannot create /usr/share/gdb  Permission denied


> 2010-08-18  Tom Tromey  <tromey@redhat.com>
> 
> 	PR python/11900:
> 	* configure: Rebuild.
> 	* configure.ac: Add install-python to CONFIG_INSTALL.
> 	* Makefile.in (install-python): New.
> 
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.1127.2.1
> diff -u -r1.1127.2.1 Makefile.in
> --- Makefile.in	28 Jul 2010 18:32:47 -0000	1.1127.2.1
> +++ Makefile.in	18 Aug 2010 22:52:22 -0000
> @@ -1037,6 +1037,8 @@
>  		$(INSTALL_DATA) $(srcdir)/gdb.1 \
>  			$(DESTDIR)$(man1dir)/$$transformed_name.1
>  
> +install-python:
> +	$(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb
>  
>  uninstall: force $(CONFIG_UNINSTALL)
>  	transformed_name=`t='$(program_transform_name)'; \
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.ac,v
> retrieving revision 1.125.2.2
> diff -u -r1.125.2.2 configure.ac
> --- configure.ac	30 Jul 2010 16:02:16 -0000	1.125.2.2
> +++ configure.ac	18 Aug 2010 22:52:23 -0000
> @@ -832,6 +832,7 @@
>    CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_PYTHON_OBS)"
>    CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_PYTHON_DEPS)"
>    CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_PYTHON_SRCS)"
> +  CONFIG_INSTALL="$CONFIG_INSTALL install-python"
>    ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_PYTHON_CFLAGS)"
>  
>    # Flags needed to compile Python code (taken from python-config --cflags).

Re: FYI: make python install directory

[Michael Snyder]

Michael Snyder wrote:
> Tom Tromey wrote:
>> I'm checking this in on the trunk and the 7.2 branch.
>>
>> PR 11900 says that gdb's breaks help with Python 2.4.
>> This happens because the gdb module's __path__ points to a directory
>> which does not exist.
>>
>> This patch fixes the problem by arranging to make the appropriate
>> directory at install time.
>>
>> Joel, I'm afraid your patches in this area will need a small update.
>> Or you can just back this out when those go in -- it doesn't matter at
>> all to me.  I went with this very minimal patch just because it seems
>> important to fix for 7.2.
> 
> This seems to generate a new build error for me:
> 
>      mkdir cannot create /usr/share/gdb  Permission denied

Err, with more context:


  /bin/sh ./../mkinstalldirs 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/share
  cats=""; for cat in $cats; do \
  	  lang=`basename $cat | sed 's/\.gmo$//'`; \
  	  if [ -f $cat ]; then :; \
  	  elif [ -f ./$cat ]; then cat=./$cat; \
  	  else continue; \
  	  fi; \
  	  dir=/usr/share/locale/$lang/LC_MESSAGES; \
  	  echo /bin/sh ./../mkinstalldirs 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root$dir; 
\
  	  /bin/sh ./../mkinstalldirs 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root$dir 
|| exit 1; \
  	  echo /usr/bin/install -c -m 644 $cat 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root$dir/gdb.mo; 
\
  	  /usr/bin/install -c -m 644 $cat 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root$dir/gdb.mo; 
\
  	done
  transformed_name=`t='s&^&&'; \
  			  echo gdbtui | sed -e "$t"` ; \
  		if test "x$transformed_name" = x; then \
  		  transformed_name=gdbtui ; \
  		else \
  		  true ; \
  		fi ; \
  		/bin/sh ./../mkinstalldirs 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/bin 
; \
  		/usr/bin/install -c gdbtui \
  		 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/bin/$transformed_name 
; \
  		/bin/sh ./../mkinstalldirs \
  		 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/share/man/man1 
; \
  		/usr/bin/install -c -m 644 ./gdb.1 \
  		 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/share/man/man1/$transformed_name.1
  mkdir -p -- 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/bin
  mkdir -p -- 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/gdb-root/usr/share/man/man1
  /bin/sh ./../mkinstalldirs /usr/share/gdb/python/gdb
  mkdir -p -- /usr/share/gdb/python/gdb
  mkdir: cannot create directory `/usr/share/gdb': Permission denied
  make[3]: *** [install-python] Error 1
  make[3]: Leaving directory 
`/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/BUILD/gdb-7.1.90.20100802/gdb'
  make[2]: *** [install-gdb] Error 2
  make[2]: Leaving directory 
`/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/BUILD/gdb-7.1.90.20100802'
  make[1]: *** [install] Error 2
  make[1]: Leaving directory 
`/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/BUILD/gdb-7.1.90.20100802'
  error: Bad exit status from 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/rpm-tmp.3052 
(%install)


  RPM build errors:
      Bad exit status from 
/build/mts/release/bora-289896/rhel52-64/gdb-7.1.90/buildroot/rpmtmp/TMP/rpm-tmp.3052 
(%install)

Re: FYI: make python install directory

[Joel Brobecker]

> >This seems to generate a new build error for me:
> >
> >     mkdir cannot create /usr/share/gdb  Permission denied
> 
> Err, with more context:

Cannot reproduce (no enough info: How did you configure, and what
commands did you use?).  Certainly, the above must have occurred
not during the build, but during the install. On my end of things:

     /bin/bash /home/brobecke/act/cvs/gdb-7.2-public.cvs/gdb/../mkinstalldirs /t.a/brobecke/bld/tst-gdb-7.2-public.cvs/install/share/gdb/python/gdb
     mkdir -p -- /t.a/brobecke/bld/tst-gdb-7.2-public.cvs/install/share/gdb/python/gdb

I tried with both HEAD and branch...

-- 
Joel

Re: FYI: make python install directory

[Tom Tromey]

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> This seems to generate a new build error for me:
Michael>     mkdir cannot create /usr/share/gdb  Permission denied

I forgot about DESTDIR.

Here is what I am going to check in.

Tom

2010-08-19  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (install-python): Add DESTDIR.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1127.2.2
diff -u -r1.1127.2.2 Makefile.in
--- Makefile.in	18 Aug 2010 22:55:55 -0000	1.1127.2.2
+++ Makefile.in	19 Aug 2010 18:37:57 -0000
@@ -1038,7 +1038,7 @@
 			$(DESTDIR)$(man1dir)/$$transformed_name.1
 
 install-python:
-	$(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb
+	$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(GDB_DATADIR)/python/gdb
 
 uninstall: force $(CONFIG_UNINSTALL)
 	transformed_name=`t='$(program_transform_name)'; \

Re: FYI: make python install directory

[Daniel Jacobowitz]

On Thu, Aug 19, 2010 at 08:25:50PM +0200, Joel Brobecker wrote:
> > >This seems to generate a new build error for me:
> > >
> > >     mkdir cannot create /usr/share/gdb  Permission denied
> > 
> > Err, with more context:
> 
> Cannot reproduce (no enough info: How did you configure, and what
> commands did you use?).  Certainly, the above must have occurred
> not during the build, but during the install. On my end of things:

Missing DESTDIR, maybe?

-- 
Daniel Jacobowitz
CodeSourcery

Re: FYI: make python install directory

[Michael Snyder]

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> This seems to generate a new build error for me:
> Michael>     mkdir cannot create /usr/share/gdb  Permission denied
> 
> I forgot about DESTDIR.
> 
> Here is what I am going to check in.

Thanks, that fixed the problem.