From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75069-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31925 invoked by alias); 19 Aug 2010 18:38:44 -0000
Received: (qmail 31913 invoked by uid 22791); 19 Aug 2010 18:38:43 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 18:38:39 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7JIcbAa023745	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 19 Aug 2010 14:38:37 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7JIca5L015345;	Thu, 19 Aug 2010 14:38:36 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7JIcZU2025745;	Thu, 19 Aug 2010 14:38:36 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 7BE49378975; Thu, 19 Aug 2010 12:38:35 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: FYI: make python install directory
References: <m3wrrn8rah.fsf@fleche.redhat.com> <4C6D71ED.2020206@vmware.com>
Date: Thu, 19 Aug 2010 18:38:00 -0000
In-Reply-To: <4C6D71ED.2020206@vmware.com> (Michael Snyder's message of "Thu,	19 Aug 2010 11:03:25 -0700")
Message-ID: <m3eidu4fdg.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00351.txt.bz2

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> This seems to generate a new build error for me:
Michael>     mkdir cannot create /usr/share/gdb  Permission denied

I forgot about DESTDIR.

Here is what I am going to check in.

Tom

2010-08-19  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (install-python): Add DESTDIR.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1127.2.2
diff -u -r1.1127.2.2 Makefile.in
--- Makefile.in	18 Aug 2010 22:55:55 -0000	1.1127.2.2
+++ Makefile.in	19 Aug 2010 18:37:57 -0000
@@ -1038,7 +1038,7 @@
 			$(DESTDIR)$(man1dir)/$$transformed_name.1
 
 install-python:
-	$(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb
+	$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(GDB_DATADIR)/python/gdb
 
 uninstall: force $(CONFIG_UNINSTALL)
 	transformed_name=`t='$(program_transform_name)'; \