From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Delayed physname computation
Date: Mon, 26 Apr 2010 18:38:00 -0000 [thread overview]
Message-ID: <m3eii2njnx.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BD22E6A.9020309@redhat.com> (Keith Seitz's message of "Fri, 23 Apr 2010 16:34:02 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Yeah, I wasn't 100% sure whether this needed a cleanup,
Keith> either. Nonetheless, we have two options, catch any errors (which I
Keith> think was suggested in another thread for a different problem) or add
Keith> a cleanup. A little paranoia can't hurt that much. If you have a
Keith> preference, I'll implement that.
One of us can handle it in a followup patch.
>> Can this call to dwarf2_physname exhibit the problem that this patch is
>> trying to circumvent?
Keith> Unfortunately, it very well could. I guess it would be almost as
Keith> useful if this called dwarf2_fullname instead. What do you think?
Yeah. I think it is important for the error case not to crash.
Printing something useful is good, maybe even the CU+DIE would be
enough.
Tom
next prev parent reply other threads:[~2010-04-26 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 20:23 Keith Seitz
2010-04-21 6:38 ` Jan Kratochvil
2010-04-23 23:04 ` Tom Tromey
2010-04-23 23:03 ` Tom Tromey
2010-04-23 23:34 ` Keith Seitz
2010-04-26 18:38 ` Tom Tromey [this message]
2010-05-11 21:18 ` Keith Seitz
2010-06-04 22:37 ` Tom Tromey
2010-04-25 10:33 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eii2njnx.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).