From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31691 invoked by alias); 26 Apr 2010 18:38:54 -0000 Received: (qmail 31674 invoked by uid 22791); 26 Apr 2010 18:38:52 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 18:38:46 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QIciIt025943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Apr 2010 14:38:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3QIchb6026385; Mon, 26 Apr 2010 14:38:44 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3QIcgPn010219; Mon, 26 Apr 2010 14:38:43 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B1332378213; Mon, 26 Apr 2010 12:38:42 -0600 (MDT) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Delayed physname computation References: <4BCE0D3C.7040201@redhat.com> <4BD22E6A.9020309@redhat.com> Reply-To: Tom Tromey Date: Mon, 26 Apr 2010 18:38:00 -0000 In-Reply-To: <4BD22E6A.9020309@redhat.com> (Keith Seitz's message of "Fri, 23 Apr 2010 16:34:02 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00887.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Yeah, I wasn't 100% sure whether this needed a cleanup, Keith> either. Nonetheless, we have two options, catch any errors (which I Keith> think was suggested in another thread for a different problem) or add Keith> a cleanup. A little paranoia can't hurt that much. If you have a Keith> preference, I'll implement that. One of us can handle it in a followup patch. >> Can this call to dwarf2_physname exhibit the problem that this patch is >> trying to circumvent? Keith> Unfortunately, it very well could. I guess it would be almost as Keith> useful if this called dwarf2_fullname instead. What do you think? Yeah. I think it is important for the error case not to crash. Printing something useful is good, maybe even the CU+DIE would be enough. Tom