From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117186 invoked by alias); 23 Jan 2018 12:53:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117167 invoked by uid 89); 23 Jan 2018 12:53:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Hx-languages-length:905 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jan 2018 12:53:05 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0NCpSr8049302 for ; Tue, 23 Jan 2018 07:53:04 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fp5a8rcnj-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Jan 2018 07:53:03 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Jan 2018 12:53:01 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 23 Jan 2018 12:52:58 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0NCqwck45088932; Tue, 23 Jan 2018 12:52:58 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4A3D3A4055; Tue, 23 Jan 2018 12:46:38 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 20476A4051; Tue, 23 Jan 2018 12:46:38 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.155]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 23 Jan 2018 12:46:38 +0000 (GMT) From: Andreas Arnez To: "Ulrich Weigand" Cc: prudo@linux.vnet.ibm.com (Philipp Rudo), gdb-patches@sourceware.org, qiyaoltc@gmail.com (Yao Qi) Subject: Re: [PATCH v4 00/11] Split up s390-linux-tdep.c References: <20180109120144.93854-1-prudo@linux.vnet.ibm.com> <20180109140934.85512D804CF@oc3748833570.ibm.com> Date: Tue, 23 Jan 2018 12:53:00 -0000 In-Reply-To: <20180109140934.85512D804CF@oc3748833570.ibm.com> (Ulrich Weigand's message of "Tue, 9 Jan 2018 15:09:34 +0100 (CET)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18012312-0012-0000-0000-000005A6D8F4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012312-0013-0000-0000-00001922605F Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-23_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801230176 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00454.txt.bz2 On Tue, Jan 09 2018, Ulrich Weigand wrote: > Hi Philipp, > >> Philipp Rudo (11): >> s390: Remove duplicate checks for cached gdbarch at init >> s390: Allocate gdbarch & tdep at start of gdbarch init >> s390: gdbarch_tdep.have_* int -> bool >> s390: gdbarch_tdep add field tdesc >> s390: Move tdesc validation to separate function >> s390: if -> gdb_assert for tdesc_has_registers check >> s390: Hook s390 into OSABI mechanism >> s390: gdbarch_tdep add hook for syscall record >> s390: Split up s390-linux-tdep.c into two files >> s390: Move record-replay to s390-tdep >> s390: Clean up s390-linux-tdep.c > > I've looked over the series again, and it looks good to me now. > So unless Andreas has further comments, I think this is OK to > commit ... Looks good to me as well. After adjusting a few ChangeLog entries I've pushed this now. Thanks, Andreas