From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: next/finish/etc -vs- exceptions
Date: Tue, 30 Nov 2010 16:43:00 -0000 [thread overview]
Message-ID: <m3fwuisqxb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101125075847.GA19270@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 25 Nov 2010 08:58:47 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Thanks for the review.
I've made most of the changes you recommended.
>> * breakpoint.h (enum bptype) <bp_exception, bp_exception_resume,
>> bp_exception_master> : New constants.
Jan> Therefore it is a precent new `bptype's are permitted instead of using
Jan> breakpoint_ops (which may need some extensions, not sure).
Yeah. Mostly I just copied and then extended the existing longjmp
support.
I looked briefly at using breakpoint_ops, but it seems like it would
require a bunch of new methods that are specific to just this
breakpoint. Maybe that is the way to go?
Jan> BTW the testcase does not work on neither ppc32 nor on ppc64.
Thanks, I will investigate.
Jan> tp-> initiating_frame should be initialized from
Jan> set_longjmp_breakpoint, as it is required for that operation.
I made this change.
Jan> It probably should not be placed in TP. If we are
Jan> stepping/until-ing/etc. some code and execute some breakpoint's
Jan> command list trying to step/next/etc. again already from a
Jan> different frame it won't work. But this is a problem for most of
Jan> the TP variables already so that's OK for this patch. It should be
Jan> carried over from the set-breakpoint to resume-breakpoint
Jan> otherwise.
I thought that gdb did not support nested inferior-control commands like
this.
It would be a nice feature.
>> + add_continuation (tp, until_next_continuation, tp, NULL);
Jan> continuation_free_args is NULL here but I think the breakpoint
Jan> should get deleted even if there is some premature thread deletion.
Jan> But maybe just all the breakpoints specific for that thread
Jan> (clear_thread_inferior_resources) should be deleted which would
Jan> also solve this problem?
I will try to make a test case so I can see what actually happens in
this scenario. Thanks for pointing it out.
>> +if { [compile_java_from_source ${srcdir}/$subdir/${srcfile} ${binfile} "-g"] != "" } {
>> + untested "Couldn't compile ${srcdir}/$subdir/${srcfile}"
>> + return -1
Jan> maybe prepare_for_testing?
Jan> (nitpick)
I left this as-is. compile_java_from_source does some extra processing
right now.
Tom
next prev parent reply other threads:[~2010-11-30 16:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 1:37 Tom Tromey
2010-11-24 17:53 ` Joel Brobecker
2010-11-24 18:24 ` Tom Tromey
2010-11-25 7:59 ` Jan Kratochvil
2010-11-27 17:25 ` Doug Evans
2010-11-28 8:29 ` Joel Brobecker
2010-11-30 16:43 ` Tom Tromey [this message]
2010-11-30 17:02 ` Jan Kratochvil
2010-11-30 17:15 ` Phil Muldoon
2010-11-30 20:15 ` Tom Tromey
2010-12-01 13:42 ` Jan Kratochvil
2010-12-01 21:40 ` Tom Tromey
2010-11-30 18:23 ` Tom Tromey
2010-11-30 18:55 ` Tom Tromey
2010-12-02 15:32 ` Tom Tromey
2010-12-09 16:37 ` Tom Tromey
2010-12-10 4:52 ` Jan Kratochvil
2010-12-10 20:07 ` Tom Tromey
2010-12-11 5:27 ` Jan Kratochvil
2010-12-15 21:18 ` Tom Tromey
[not found] <m37hzzzgk7.fsf@fleche.redhat.com>
[not found] ` <20090610161204.GB25703@adacore.com>
[not found] ` <m3hbyoghit.fsf@fleche.redhat.com>
[not found] ` <200906101806.31977.pedro@codesourcery.com>
[not found] ` <20090610171328.GA32661@caradoc.them.org>
2010-11-25 4:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwuisqxb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).