public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	JuYoung Kim <j0.kim@samsung.com>,
	       Eli Zaretskii <eliz@gnu.org>,
	       "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch]change dwarf2_start_subfile() to adapt	inappropriate dir name
Date: Tue, 23 Nov 2010 20:47:00 -0000	[thread overview]
Message-ID: <m3fwur3h0k.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101115180513.GJ8544@codesourcery.com> (Nathan Froyd's message	of "Mon, 15 Nov 2010 10:05:14 -0800")

>>>>> "Nathan" == Nathan Froyd <froydnj@codesourcery.com> writes:

Nathan> FWIW, we encountered this problem as well.  This is the patch we used to
Nathan> fix it.  It's very similar to the proposed patch, but slightly more
Nathan> complete.

Thanks.

Nathan> +      if (dirname[dir_len-1] == SLASH_STRING[0])

Noting Eli's note...

Nathan> +	memmove (concat_name+dir_len-1, concat_name+dir_len,

Spaces around the operators.

Nathan> +		 /* SLASH_STRING and trailing NULL */
Nathan> +		 strlen (filename) + 1 + 1);

I think it is mildly better to use strlen (SLASH_STRING) rather than 1.
Or just call concat two different ways instead of memmove.

This is ok with these nits fixed.

Tom

  parent reply	other threads:[~2010-11-23 20:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15  6:25 JuYoung Kim
2010-11-15 16:58 ` Joel Brobecker
2010-11-15 18:05   ` Nathan Froyd
2010-11-15 18:34     ` Eli Zaretskii
2010-11-23 20:47     ` Tom Tromey [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-11-15  1:21 JuYoung Kim
2010-11-15  4:09 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fwur3h0k.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=froydnj@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=j0.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).