From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12409 invoked by alias); 22 Jul 2010 14:14:19 -0000 Received: (qmail 12399 invoked by uid 22791); 22 Jul 2010 14:14:18 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Jul 2010 14:13:41 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6MEDbsw022361 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Jul 2010 10:13:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6MEDaLx026384; Thu, 22 Jul 2010 10:13:37 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6MEDZpp001669; Thu, 22 Jul 2010 10:13:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 10A5A3797F3; Thu, 22 Jul 2010 08:13:35 -0600 (MDT) From: Tom Tromey To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Subject: Re: [0/4] RFC: add DWARF index support References: Date: Thu, 22 Jul 2010 14:14:00 -0000 In-Reply-To: (Paul Pluzhnikov's message of "Wed, 21 Jul 2010 21:27:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00349.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Paul> I am seeing crashes in code which appears to have been committed Paul> in this patch: Paul> I've briefly perused dwarf2read.c, and didn't find a place that Paul> insures that per_cu->objfile is initialized :-( Sorry about that. The immediate problem is that a dwarf2_per_cu_data is embedded in struct signatured_type, and initialized in create_debug_types_hash_table. This embedded struct doesn't get its objfile member initialized. The other places allocating a dwarf2_per_cu_data are create_all_comp_units and create_cus_from_index. Those places do initialize that member. The bigger problem is that I completely forgot about .debug_types. I am not certain that a simple fix will work if we have both .debug_types and .gdb_index. I will try that out. Tom