From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110292 invoked by alias); 23 Aug 2015 04:11:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110273 invoked by uid 89); 23 Aug 2015 04:11:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f48.google.com Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 04:10:59 +0000 Received: by pacdd16 with SMTP id dd16so71555634pac.2 for ; Sat, 22 Aug 2015 21:10:57 -0700 (PDT) X-Received: by 10.68.254.99 with SMTP id ah3mr32395675pbd.15.1440303057853; Sat, 22 Aug 2015 21:10:57 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id ld8sm12664726pbc.61.2015.08.22.21.10.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Aug 2015 21:10:57 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 12/19] Implement completion limiting for sim_command_completer. References: <20150806191404.32159.50755.stgit@valrhona.uglyboxes.com> <20150806191857.32159.87692.stgit@valrhona.uglyboxes.com> Date: Sun, 23 Aug 2015 04:11:00 -0000 In-Reply-To: <20150806191857.32159.87692.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 06 Aug 2015 12:19:17 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00651.txt.bz2 Keith Seitz writes: > There are no revisions in this version. > > -- > > This patch converts sim_command_completer to use add_completion. > It does not add any tests, since the `sim' command is highly > target-dependent and unimplemented for the majority of simulators. > > gdb/ChangeLog > > * remote-sim.c: Include completer.h. > (sim_command_completer): Use add_completion. LGTM