* [PATCH] testsuite: info-shared.exp: Expect leading dot on ppc64's symbols
@ 2014-01-22 19:18 Edjunior Barbosa Machado
2014-01-22 19:42 ` Sergio Durigan Junior
2014-01-28 15:59 ` [PATCH] testsuite: info-shared.exp: Expect leading.on " Ulrich Weigand
0 siblings, 2 replies; 7+ messages in thread
From: Edjunior Barbosa Machado @ 2014-01-22 19:18 UTC (permalink / raw)
To: gdb-patches
Hi,
With this patch, the testcase permits the leading `.' found on ppc64's symbols.
It fixes 10 false unexpected failures on ppc64. Ok?
Thanks,
Edjunior.
gdb/testsuite/
2014-01-22 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* gdb.base/info-shared.exp: Expect leading `.' on ppc64's symbols.
---
gdb/testsuite/gdb.base/info-shared.exp | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/gdb/testsuite/gdb.base/info-shared.exp b/gdb/testsuite/gdb.base/info-shared.exp
index b7be174..a7cbe1d 100644
--- a/gdb/testsuite/gdb.base/info-shared.exp
+++ b/gdb/testsuite/gdb.base/info-shared.exp
@@ -89,18 +89,18 @@ gdb_breakpoint "foo" allow-pending
gdb_breakpoint "bar" allow-pending
# Run to the first stop and check that only the first library is loaded.
-gdb_continue_to_breakpoint "library load #1" "stop .*"
+gdb_continue_to_breakpoint "library load #1" "\\.?stop .*"
check_info_shared "info sharedlibrary #2" 1 0
# Run to the second stop and check that both libraries are loaded.
-gdb_continue_to_breakpoint "library load #2" "stop .*"
+gdb_continue_to_breakpoint "library load #2" "\\.?stop .*"
check_info_shared "info sharedlibrary #3" 1 1
# Check that the next stop is in foo.
-gdb_continue_to_breakpoint "library function #1" "foo .*"
+gdb_continue_to_breakpoint "library function #1" "\\.?foo .*"
# Check that the next stop is in bar.
-gdb_continue_to_breakpoint "library function #2" "bar .*"
+gdb_continue_to_breakpoint "library function #2" "\\.?bar .*"
# Restart the inferior and make sure there are no breakpoint reset
# errors. These can happen with the probes-based runtime linker
@@ -124,23 +124,23 @@ gdb_test_multiple "" $test {
check_info_shared "info sharedlibrary #4" 0 0
# Run to the first stop and check that only the first library is loaded.
-gdb_continue_to_breakpoint "library load #3" "stop .*"
+gdb_continue_to_breakpoint "library load #3" "\\.?stop .*"
check_info_shared "info sharedlibrary #5" 1 0
# Run to the second stop and check that both libraries are loaded.
-gdb_continue_to_breakpoint "library load #4" "stop .*"
+gdb_continue_to_breakpoint "library load #4" "\\.?stop .*"
check_info_shared "info sharedlibrary #6" 1 1
# Check that the next stop is in foo.
-gdb_continue_to_breakpoint "library function #3" "foo .*"
+gdb_continue_to_breakpoint "library function #3" "\\.?foo .*"
# Check that the next stop is in bar.
-gdb_continue_to_breakpoint "library function #4" "bar .*"
+gdb_continue_to_breakpoint "library function #4" "\\.?bar .*"
# Run to the next stop and check that the first library has been unloaded.
-gdb_continue_to_breakpoint "library unload #1" "stop .*"
+gdb_continue_to_breakpoint "library unload #1" "\\.?stop .*"
check_info_shared "info sharedlibrary #7" 0 1
# Run to the last stop and check that both libraries are gone.
-gdb_continue_to_breakpoint "library unload #2" "stop .*"
+gdb_continue_to_breakpoint "library unload #2" "\\.?stop .*"
check_info_shared "info sharedlibrary #8" 0 0
--
1.8.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: info-shared.exp: Expect leading dot on ppc64's symbols
2014-01-22 19:18 [PATCH] testsuite: info-shared.exp: Expect leading dot on ppc64's symbols Edjunior Barbosa Machado
@ 2014-01-22 19:42 ` Sergio Durigan Junior
2014-01-22 20:52 ` Sergio Durigan Junior
2014-01-28 15:59 ` [PATCH] testsuite: info-shared.exp: Expect leading.on " Ulrich Weigand
1 sibling, 1 reply; 7+ messages in thread
From: Sergio Durigan Junior @ 2014-01-22 19:42 UTC (permalink / raw)
To: Edjunior Barbosa Machado; +Cc: gdb-patches
On Wednesday, January 22 2014, Edjunior Barbosa Machado wrote:
> Hi,
>
> With this patch, the testcase permits the leading `.' found on ppc64's symbols.
> It fixes 10 false unexpected failures on ppc64. Ok?
I believe this also fixes the regressions I found on PPC64 + RHEL 6.5
for the 7.7 branch. I will test the patch and get back with the results.
Thanks,
--
Sergio
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: info-shared.exp: Expect leading dot on ppc64's symbols
2014-01-22 19:42 ` Sergio Durigan Junior
@ 2014-01-22 20:52 ` Sergio Durigan Junior
0 siblings, 0 replies; 7+ messages in thread
From: Sergio Durigan Junior @ 2014-01-22 20:52 UTC (permalink / raw)
To: Edjunior Barbosa Machado; +Cc: gdb-patches
On Wednesday, January 22 2014, I wrote:
> I believe this also fixes the regressions I found on PPC64 + RHEL 6.5
> for the 7.7 branch. I will test the patch and get back with the results.
Confirmed, it fixes the failures indeed.
IMO this patch could/should also be applied to the 7.7 branch.
Thanks,
--
Sergio
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: info-shared.exp: Expect leading.on ppc64's symbols
2014-01-22 19:18 [PATCH] testsuite: info-shared.exp: Expect leading dot on ppc64's symbols Edjunior Barbosa Machado
2014-01-22 19:42 ` Sergio Durigan Junior
@ 2014-01-28 15:59 ` Ulrich Weigand
2014-01-28 16:36 ` Joel Brobecker
1 sibling, 1 reply; 7+ messages in thread
From: Ulrich Weigand @ 2014-01-28 15:59 UTC (permalink / raw)
To: Edjunior Barbosa Machado; +Cc: gdb-patches
Edjunior Barbosa Machado wrote:
> gdb/testsuite/
> 2014-01-22 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
>
> * gdb.base/info-shared.exp: Expect leading `.' on ppc64's symbols.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: info-shared.exp: Expect leading.on ppc64's symbols
2014-01-28 15:59 ` [PATCH] testsuite: info-shared.exp: Expect leading.on " Ulrich Weigand
@ 2014-01-28 16:36 ` Joel Brobecker
2014-01-28 17:39 ` Edjunior Barbosa Machado
2014-01-28 19:23 ` Sergio Durigan Junior
0 siblings, 2 replies; 7+ messages in thread
From: Joel Brobecker @ 2014-01-28 16:36 UTC (permalink / raw)
To: Ulrich Weigand; +Cc: Edjunior Barbosa Machado, gdb-patches
> Edjunior Barbosa Machado wrote:
>
> > gdb/testsuite/
> > 2014-01-22 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
> >
> > * gdb.base/info-shared.exp: Expect leading `.' on ppc64's symbols.
>
> This is OK.
I think this patch might be one of the patches that Sergio mentioned
in: https://www.sourceware.org/ml/gdb-patches/2014-01/msg00990.html
If that's the case, they definitely seem OK for the branch as well.
--
Joel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: info-shared.exp: Expect leading.on ppc64's symbols
2014-01-28 16:36 ` Joel Brobecker
@ 2014-01-28 17:39 ` Edjunior Barbosa Machado
2014-01-28 19:23 ` Sergio Durigan Junior
1 sibling, 0 replies; 7+ messages in thread
From: Edjunior Barbosa Machado @ 2014-01-28 17:39 UTC (permalink / raw)
To: Joel Brobecker, Ulrich Weigand; +Cc: gdb-patches
On 01/28/2014 02:36 PM, Joel Brobecker wrote:
>> Edjunior Barbosa Machado wrote:
>>
>>> gdb/testsuite/
>>> 2014-01-22 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
>>>
>>> * gdb.base/info-shared.exp: Expect leading `.' on ppc64's symbols.
>>
>> This is OK.
>
> I think this patch might be one of the patches that Sergio mentioned
> in: https://www.sourceware.org/ml/gdb-patches/2014-01/msg00990.html
>
> If that's the case, they definitely seem OK for the branch as well.
Thank you folks, I've just pushed the changes to both master and gdb-7.7
branches:
<https://sourceware.org/ml/gdb-cvs/2014-01/msg00131.html>
<https://sourceware.org/ml/gdb-cvs/2014-01/msg00132.html>
--
Edjunior
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: info-shared.exp: Expect leading.on ppc64's symbols
2014-01-28 16:36 ` Joel Brobecker
2014-01-28 17:39 ` Edjunior Barbosa Machado
@ 2014-01-28 19:23 ` Sergio Durigan Junior
1 sibling, 0 replies; 7+ messages in thread
From: Sergio Durigan Junior @ 2014-01-28 19:23 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Ulrich Weigand, Edjunior Barbosa Machado, gdb-patches
On Tuesday, January 28 2014, Joel Brobecker wrote:
> I think this patch might be one of the patches that Sergio mentioned
> in: https://www.sourceware.org/ml/gdb-patches/2014-01/msg00990.html
>
> If that's the case, they definitely seem OK for the branch as well.
Yes, that's it Joel. Thank you both!
--
Sergio
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-28 19:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-22 19:18 [PATCH] testsuite: info-shared.exp: Expect leading dot on ppc64's symbols Edjunior Barbosa Machado
2014-01-22 19:42 ` Sergio Durigan Junior
2014-01-22 20:52 ` Sergio Durigan Junior
2014-01-28 15:59 ` [PATCH] testsuite: info-shared.exp: Expect leading.on " Ulrich Weigand
2014-01-28 16:36 ` Joel Brobecker
2014-01-28 17:39 ` Edjunior Barbosa Machado
2014-01-28 19:23 ` Sergio Durigan Junior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).