From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Add visible flag to breakpoints.
Date: Tue, 05 Oct 2010 22:28:00 -0000 [thread overview]
Message-ID: <m3hbh0s29j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m38w2j72jd.fsf@redhat.com> (Phil Muldoon's message of "Thu, 30 Sep 2010 15:02:14 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> This patch allows breakpoints to be become invisible to the user.
I have a couple additional notes on this patch.
Phil> +static PyObject *
Phil> +bppy_get_visibility (PyObject *self, void *closure)
[...]
I think it would be handy to keep this attribute around in the next
revision of the patch, even if it is not writeable.
Phil> + if (! PyArg_ParseTupleAndKeywords (args, kwargs, "s|iii", keywords,
Phil> + &spec, &type, &access_type, &visible))
I think this should be "s|iiO", and then use PyObject_IsTrue to
determine whether the argument is true or false. I think this is more
idiomatic than an integer argument. Also, I think the documentation
should be updated to indicate that this argument is a boolean.
Tom
prev parent reply other threads:[~2010-10-05 22:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 16:28 Phil Muldoon
2010-09-30 16:41 ` Daniel Jacobowitz
2010-09-30 17:51 ` Phil Muldoon
2010-09-30 17:55 ` Pedro Alves
2010-09-30 18:12 ` Phil Muldoon
2010-10-08 12:51 ` Phil Muldoon
2010-10-08 13:35 ` Pedro Alves
2010-10-08 14:04 ` Phil Muldoon
2010-10-08 18:44 ` Tom Tromey
2010-10-12 20:25 ` Phil Muldoon
2010-10-12 21:34 ` Tom Tromey
2010-10-13 12:45 ` Phil Muldoon
2010-10-13 13:06 ` Phil Muldoon
2010-10-13 15:36 ` Tom Tromey
2010-10-16 18:42 ` Pedro Alves
2010-10-16 19:03 ` Pedro Alves
2010-10-18 16:09 ` Tom Tromey
2010-10-22 21:05 ` Phil Muldoon
2010-10-22 21:31 ` Eli Zaretskii
2010-10-22 21:37 ` Phil Muldoon
2010-10-23 9:07 ` Eli Zaretskii
2010-10-31 21:07 ` Pedro Alves
2010-11-11 14:36 ` Phil Muldoon
2010-11-12 12:43 ` Ken Werner
2010-11-12 12:49 ` Pedro Alves
2010-11-12 12:58 ` Ken Werner
2010-10-08 18:40 ` Tom Tromey
2010-09-30 17:04 ` Pedro Alves
2010-09-30 17:55 ` Phil Muldoon
2010-09-30 17:51 ` Eli Zaretskii
2010-10-05 22:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbh0s29j.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).