From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28686 invoked by alias); 5 Oct 2010 22:28:33 -0000 Received: (qmail 28633 invoked by uid 22791); 5 Oct 2010 22:28:32 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Oct 2010 22:28:27 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o95MSQdp032718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Oct 2010 18:28:26 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o95MSPEf023443; Tue, 5 Oct 2010 18:28:26 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o95MSPjt028000; Tue, 5 Oct 2010 18:28:25 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1C72C379C1A; Tue, 5 Oct 2010 16:28:25 -0600 (MDT) From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [patch] Add visible flag to breakpoints. References: Date: Tue, 05 Oct 2010 22:28:00 -0000 In-Reply-To: (Phil Muldoon's message of "Thu, 30 Sep 2010 15:02:14 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00060.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> This patch allows breakpoints to be become invisible to the user. I have a couple additional notes on this patch. Phil> +static PyObject * Phil> +bppy_get_visibility (PyObject *self, void *closure) [...] I think it would be handy to keep this attribute around in the next revision of the patch, even if it is not writeable. Phil> + if (! PyArg_ParseTupleAndKeywords (args, kwargs, "s|iii", keywords, Phil> + &spec, &type, &access_type, &visible)) I think this should be "s|iiO", and then use PyObject_IsTrue to determine whether the argument is true or false. I think this is more idiomatic than an integer argument. Also, I think the documentation should be updated to indicate that this argument is a boolean. Tom