From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75580-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30604 invoked by alias); 14 Sep 2010 20:56:56 -0000
Received: (qmail 30596 invoked by uid 22791); 14 Sep 2010 20:56:55 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Sep 2010 20:56:49 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8EKuhwt020503	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 14 Sep 2010 16:56:44 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8EKugQl019709;	Tue, 14 Sep 2010 16:56:42 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8EKufGa015655;	Tue, 14 Sep 2010 16:56:42 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 93C733784BE; Tue, 14 Sep 2010 14:56:41 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: Your INTERMEDIATE_ENCODING patch for Solaris
References: <20100731162500.32FAE5664F4@henry1.codesourcery.com>	<m37hk4x5r0.fsf@fleche.redhat.com> <m3eidxi069.fsf@fleche.redhat.com>	<20100817184407.GC3599@adacore.com> <m3aaolgj0g.fsf@fleche.redhat.com>	<20100818101406.GA2903@adacore.com>	<15264.6257346079$1282142643@news.gmane.org>	<m38w43dho9.fsf@fleche.redhat.com>	<004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr>	<m34oeq8u1g.fsf@fleche.redhat.com> <m339twkmj5.fsf@fleche.redhat.com>	<001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr>	<m3k4n6hgqe.fsf@fleche.redhat.com>	<44796.6229789474$1283326243@news.gmane.org>	<m362yp9kaj.fsf@fleche.redhat.com>	<000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr>	<m362yo88fj.fsf@fleche.redhat.com>
Date: Tue, 14 Sep 2010 21:29:00 -0000
In-Reply-To: <m362yo88fj.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu,	02 Sep 2010 09:35:44 -0600")
Message-ID: <m3hbhs59iu.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-09/txt/msg00275.txt.bz2

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Pierre> Probably just define PHONY_ICONV if the first set of conditions is
Pierre> not met (by the way, I am not sure the libiconv version test
Pierre> that we added is really pertinent.)

Tom> Thanks.  I think I got the logic wrong:

Tom> +/* If we got here and have wchar_t support, we might be on a system
Tom> +   with some problem.  So, we just disable everything.  */
Tom> +#if !(defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC))
Tom> +#define PHONY_ICONV
Tom> +#endif

Tom> I think that "!" is wrong -- it even contradicts the comment.
Tom> I'm sorry to keep bothering you about this, but could you remove that
Tom> "!" and try again?

Any word on this?
I would like to commit this patch if it seems ok.

Tom