From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75432-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20115 invoked by alias); 3 Sep 2010 15:36:06 -0000
Received: (qmail 20105 invoked by uid 22791); 3 Sep 2010 15:36:05 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Sep 2010 15:35:58 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o83FZrbp005054	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 3 Sep 2010 11:35:53 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o83FZqRP011597;	Fri, 3 Sep 2010 11:35:52 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o83FZp5Q030287;	Fri, 3 Sep 2010 11:35:52 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 513D13792BC; Fri,  3 Sep 2010 09:35:51 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix DW_OP_call2 and DW_OP_call4 for max-cache-age 0
References: <20100823185008.GA2926@host1.dyn.jankratochvil.net>	<AANLkTimhw307GT1dxA5LFBnCA1njK1vk4+Sk8oamafkX@mail.gmail.com>	<20100902160216.GA10848@host1.dyn.jankratochvil.net>
Date: Fri, 03 Sep 2010 15:42:00 -0000
In-Reply-To: <20100902160216.GA10848@host1.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 2 Sep 2010 18:02:16 +0200")
Message-ID: <m3hbi66drd.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-09/txt/msg00127.txt.bz2

Jan> I would change "max-cache-age" to "max-cache-size" and call it from
Jan> prepare_execute_command() instead.  I will provide a patch if not replied.

Changing it to be size-based makes sense to me.
I don't get the rationale for putting it in prepare_execute_command.
If we are flushing the cache based on memory use, then we only need to
consider flushing it just before we read a CU.

Tom