From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1224 invoked by alias); 18 Aug 2010 22:15:51 -0000 Received: (qmail 1216 invoked by uid 22791); 18 Aug 2010 22:15:50 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Aug 2010 22:15:44 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7IMFh4q012006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Aug 2010 18:15:43 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7IMFgOR004473; Wed, 18 Aug 2010 18:15:42 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7IMFfdF031621; Wed, 18 Aug 2010 18:15:41 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4FC7F378196; Wed, 18 Aug 2010 16:15:41 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/3 optional] Template Lookup References: <4C446F53.7000209@redhat.com> Date: Wed, 18 Aug 2010 22:15:00 -0000 In-Reply-To: <4C446F53.7000209@redhat.com> (sami wagiaalla's message of "Mon, 19 Jul 2010 11:29:23 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00319.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> This patch improves the output provided by patch 2 in the series. It Sami> makes the meta symbol created for templates aware of its instanced Sami> within scope. Sami> + struct symbol_list_element* instance = symbol_get_template_instances (var); Space before "*", not after. There are a few of these. Sami> + new_instance->sym = instance; Sami> + new_instance->next = sym->ginfo.value.instances; Sami> + sym->ginfo.value.instances = new_instance; You could save a little memory by making a "subclass" of symbol for just these instances, and have the subclass include the link. Sami> +extern struct symbol_list_element* Sami> +symbol_get_template_instances (struct symbol* sym); It seems like this could return a 'const struct symbol_list_element *'. And perhaps accept a 'const struct symbol *'. I didn't really examine the other patches for const opportunities, but I think it would be worthwhile to look at. Tom