From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63691 invoked by alias); 10 Aug 2015 19:45:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63679 invoked by uid 89); 10 Aug 2015 19:45:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 10 Aug 2015 19:45:08 +0000 Received: by pacrr5 with SMTP id rr5so110100098pac.3 for ; Mon, 10 Aug 2015 12:45:07 -0700 (PDT) X-Received: by 10.66.63.99 with SMTP id f3mr48642590pas.6.1439235907114; Mon, 10 Aug 2015 12:45:07 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id ew13sm6251539pac.25.2015.08.10.12.45.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Aug 2015 12:45:06 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v6 9/9] Explicit locations: documentation updates References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> <20150805233334.21646.29492.stgit@valrhona.uglyboxes.com> Date: Mon, 10 Aug 2015 19:45:00 -0000 In-Reply-To: <20150805233334.21646.29492.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Wed, 05 Aug 2015 16:33:59 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00228.txt.bz2 Keith Seitz writes: > * This patch has previously been approved but contains modifications. * > > Differences in this revision: > > 1. NEWS items moved to "Changes since GDB 7.10" section. > > -- > > This patch adds documentation for explicit locations to both the > User Manual and gdb's online help system. > > gdb/ChangeLog: > > * NEWS: Mention explicit locations. > * breakpoint.c [LOCATION_HELP_STRING]: New macro. > [BREAK_ARGS_HELP]: Use LOCATION_HELP_STRING. > (_initialize_breakpoint): Update documentation for > "clear", "break", "trace", "strace", "ftrace", and "dprintf". > > gdb/doc/ChangeLog: > > * gdb.texinfo (Thread-Specific Breakpoints, Printing Source Lines): > Use "location(s)"instead of "linespec(s)". > (Specifying a Location): Rewrite. > Add subsections describing linespec, address, and explicit locations. > Add node/menu for each subsection. > (Source and Machine Code, C Preprocessor Macros) > (Create and Delete Trace points) > (Extensions for Ada Tasks): Use "location(s)" instead of "linespec(s)". > (Continuing at a Different Address): Remove "linespec" examples. > Add reference to "Specify a Location" > (The -break-insert Command): Rewrite. Add anchor. > Add reference to appropriate manual section discussing locations. > (The -dprintf-insert Command): Refer to -break-insert for > specification of 'location'. > > gdb/testsuite/ChangeLog: > > * gdb.base/help.exp: Update help_breakpoint_text. Hi. I'd say the previous approval is sufficient given the obvious nature of the change.