From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81087 invoked by alias); 1 Mar 2015 21:15:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81051 invoked by uid 89); 1 Mar 2015 21:15:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 01 Mar 2015 21:15:25 +0000 Received: by paceu11 with SMTP id eu11so37800442pac.10 for ; Sun, 01 Mar 2015 13:15:24 -0800 (PST) X-Received: by 10.68.69.103 with SMTP id d7mr13939741pbu.110.1425244524232; Sun, 01 Mar 2015 13:15:24 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id kn4sm9945910pab.48.2015.03.01.13.15.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Mar 2015 13:15:22 -0800 (PST) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 8/9] Explicit locations: MI support for explicit locations References: <20150217220619.1312.39861.stgit@valrhona.uglyboxes.com> <20150217220656.1312.14775.stgit@valrhona.uglyboxes.com> Date: Sun, 01 Mar 2015 21:15:00 -0000 In-Reply-To: <20150217220656.1312.14775.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Tue, 17 Feb 2015 14:06:56 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00025.txt.bz2 Keith Seitz writes: > This patch adds support for explicit locations to MI's -break-insert > command. The new options, documented in the User Manual, are > --source, --line, --function, and --label. > > gdb/ChangeLog: > > * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Add support for > explicit locations, options "--source", "--function", > "--label", and "--line". > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-break.exp (test_explicit_breakpoints): New proc. > (at toplevel): Call test_explicit_breakpoints. > * gdb.mi/mi-dprintf.exp: Add tests for explicit dprintf > breakpoints. > * lib/mi-support.exp (mi_make_breakpoint): Add support for > breakpoint conditions, "-cond". LGTM