From: Doug Evans <xdje42@gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4 v19] Add xmethod interface to the extension language API
Date: Mon, 02 Jun 2014 04:03:00 -0000 [thread overview]
Message-ID: <m3iookdkle.fsf@sspiff.org> (raw)
In-Reply-To: <CAGyQ6gwU2Geg_zK78u6Z6H3etMrwVptAoQD2DyAkuS6h7+8zYw@mail.gmail.com> (Siva Chandra's message of "Fri, 30 May 2014 15:59:00 -0700")
Siva Chandra <sivachandra@google.com> writes:
> Small change around the invoke_method API as compared to v18. Patch attached.
>
> ChangeLog
>
> 2014-05-30 Siva Chandra Reddy <sivachandra@google.com>
>
> * defs.h (enum lval_type): New enumerator "lval_xcallable".
> * extension-priv.h (struct extension_language_ops): Add the
> xmethod interface.
> * extension.c (new_xmethod_worker, clone_xmethod_worker,
> get_matching_xmethod_workers, get_xmethod_argtypes,
> invoke_xmethod, free_xmethod_worker,
> free_xmethod_worker_vec): New functions.
> * extension.h: #include "common/vec.h".
> New function declarations.
> (struct xmethod_worker): New struct.
> (VEC (xmethod_worker_ptr)): New vector type.
> (xmethod_worker_ptr): New typedef.
> (xmethod_worker_vec): Likewise.
> * gdbtypes.c (gdbtypes_post_init): Initialize "xmethod" field of
> builtin_type.
> * gdbtypes.h (enum type_code): New enumerator TYPE_CODE_XMETHOD.
> (struct builtin_type): New field "xmethod".
> * valarith.c (value_ptradd): Assert that the value argument is not
> lval_xcallable.
> * valops.c (value_must_coerce_to_target): Return 0 for
> lval_xcallable values.
> * value.c (struct value): New field XM_WORKER in the field
> LOCATION.
> (value_address, value_raw_address): Return 0 for lval_xcallable
> values.
> (set_value_address): Assert that the value is not an
> lval_xcallable.
> (value_free): Free the associated xmethod worker when freeing
> lval_xcallable values.
> (set_value_component_location): Assert that the WHOLE value is not
> lval_xcallable.
> (value_of_xmethod, call_xmethod): New functions.
> * value.h: Declare "struct xmethod_worker".
> Declare new functions value_of_xmethod, call_xmethod.
LGTM
prev parent reply other threads:[~2014-06-02 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 22:59 Siva Chandra
2014-06-02 4:03 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iookdkle.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).