From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21089 invoked by alias); 7 Oct 2010 17:53:42 -0000 Received: (qmail 21079 invoked by uid 22791); 7 Oct 2010 17:53:41 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Oct 2010 17:53:35 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o97HrJWi004102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Oct 2010 13:53:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o97HrIdB005831; Thu, 7 Oct 2010 13:53:18 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o97HrHGl001838; Thu, 7 Oct 2010 13:53:17 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2A07237897F; Thu, 7 Oct 2010 11:53:17 -0600 (MDT) From: Tom Tromey To: Hilfinger@cs.berkeley.edu Cc: Hilfinger@adacore.com, gdb-patches@sourceware.org Subject: Re: [RFA] Rework symbol searches to move Ada-specific stuff to ada-lang.c. References: <201010050842.o958gDNO002818@syracuse.mckusick.com> <1286424854.1821.2.camel@syracuse.mckusick.com> Date: Thu, 07 Oct 2010 17:53:00 -0000 In-Reply-To: <1286424854.1821.2.camel@syracuse.mckusick.com> (Paul Hilfinger's message of "Wed, 06 Oct 2010 21:14:14 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00125.txt.bz2 >>>>> "Paul" == Paul Hilfinger writes: Paul> + return (*top); Tom> A few places have parens here, but they aren't needed. Tom> Just write "return *top;". Paul> OK (BTW: That line was copied from the original). Oh, ok. I had looked to see if this was the case, but I must have missed it. My view is that it is always ok to leave code as-is when moving it around. I recommend pushing back on reviewers who ask for changes to the context of a patch :-) Tom