From: Doug Evans <xdje42@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH c++ 05/12] guile: Constify gdbscm_with_guile return value
Date: Mon, 26 Oct 2015 11:45:00 -0000 [thread overview]
Message-ID: <m3k2qab3v4.fsf@sspiff.org> (raw)
In-Reply-To: <1445831204-16588-5-git-send-email-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 25 Oct 2015 23:46:37 -0400")
Simon Marchi <simon.marchi@polymtl.ca> writes:
> Initially fixess:
>
> /home/simark/src/binutils-gdb/gdb/guile/scm-disasm.c: In function ‘void* gdbscm_disasm_read_memory_worker(void*)’:
> /home/simark/src/binutils-gdb/gdb/guile/scm-disasm.c:93:12: error: invalid conversion from ‘const void*’ to ‘void*’ [-fpermissive]
> return "seek error";
>
> This makes const the whole path that leads to the return of
> gdbscm_with_guile.
>
> gdb/ChangeLog:
>
> * guile/guile-internal.h (gdbscm_with_guile): Constify function
> pointer return value and self return value.
> * guile/scm-safe-call.c (gdbscm_with_guile): Likewise.
> (struct c_data) <func>: Constify return value.
> (struct c_data) <result>: Constify.
> (scscm_eval_scheme_string): Constify return value.
> (gdbscm_safe_eval_string): Constify status variable.
> (scscm_source_scheme_script): Constify return value.
> (gdbscm_safe_source_script): Constify status variable.
> * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker):
> Constify returrn value.
> (gdbscm_disasm_read_memory): Constify status variable.
Hi.
How about instead having gdbscm_with_guile return a const char *.
That should, for example, remove the need for any cast here in
gdbscm_safe_source_script (and presumably elsewhere):
if (result != NULL)
return xstrdup ((char *) result);
>
> diff --git a/gdb/guile/guile-internal.h b/gdb/guile/guile-internal.h
> index 017309a..0af01d2 100644
> --- a/gdb/guile/guile-internal.h
> +++ b/gdb/guile/guile-internal.h
> @@ -384,7 +384,7 @@ extern void gdbscm_memory_error (const char *subr, const char *msg, SCM args)
>
> /* scm-safe-call.c */
>
> -extern void *gdbscm_with_guile (void *(*func) (void *), void *data);
> +extern const void *gdbscm_with_guile (const void *(*func) (void *), void *data);
>
> extern SCM gdbscm_call_guile (SCM (*func) (void *), void *data,
> excp_matcher_func *ok_excps);
> diff --git a/gdb/guile/scm-disasm.c b/gdb/guile/scm-disasm.c
> index d1572c7..63889c1 100644
> --- a/gdb/guile/scm-disasm.c
> +++ b/gdb/guile/scm-disasm.c
> @@ -76,7 +76,7 @@ dascm_make_insn (CORE_ADDR pc, const char *assembly, int insn_len)
> Scheme port. Called via gdbscm_call_guile.
> The result is a statically allocated error message or NULL if success. */
>
> -static void *
> +static const void *
> gdbscm_disasm_read_memory_worker (void *datap)
> {
> struct gdbscm_disasm_read_data *data
> @@ -109,7 +109,7 @@ gdbscm_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr,
> struct disassemble_info *dinfo)
> {
> struct gdbscm_disasm_read_data data;
> - void *status;
> + const void *status;
>
> data.memaddr = memaddr;
> data.myaddr = myaddr;
> diff --git a/gdb/guile/scm-safe-call.c b/gdb/guile/scm-safe-call.c
> index 62aec0f..85a2a5b 100644
> --- a/gdb/guile/scm-safe-call.c
> +++ b/gdb/guile/scm-safe-call.c
> @@ -28,10 +28,10 @@
>
> struct c_data
> {
> - void *(*func) (void *);
> + const void *(*func) (void *);
> void *data;
> /* An error message or NULL for success. */
> - void *result;
> + const void *result;
> };
>
> /* Struct to marshall args through gdbscm_with_catch. */
> @@ -167,8 +167,8 @@ gdbscm_with_catch (void *data)
> The result if NULL if no exception occurred, otherwise it is a statically
> allocated error message (caller must *not* free). */
>
> -void *
> -gdbscm_with_guile (void *(*func) (void *), void *data)
> +const void *
> +gdbscm_with_guile (const void *(*func) (void *), void *data)
> {
> struct c_data c_data;
> struct with_catch_data catch_data;
> @@ -369,7 +369,7 @@ struct eval_scheme_string_data
> /* Wrapper to eval a C string in the Guile interpreter.
> This is passed to gdbscm_with_guile. */
>
> -static void *
> +static const void *
> scscm_eval_scheme_string (void *datap)
> {
> struct eval_scheme_string_data *data
> @@ -398,12 +398,12 @@ char *
> gdbscm_safe_eval_string (const char *string, int display_result)
> {
> struct eval_scheme_string_data data = { string, display_result };
> - void *result;
> + const void *result;
>
> result = gdbscm_with_guile (scscm_eval_scheme_string, (void *) &data);
>
> if (result != NULL)
> - return xstrdup ((char *) result);
> + return xstrdup ((const char *) result);
> return NULL;
> }
> \f
> @@ -411,7 +411,7 @@ gdbscm_safe_eval_string (const char *string, int display_result)
>
> /* Helper function for gdbscm_safe_source_scheme_script. */
>
> -static void *
> +static const void *
> scscm_source_scheme_script (void *data)
> {
> const char *filename = (const char *) data;
> @@ -439,7 +439,7 @@ gdbscm_safe_source_script (const char *filename)
> by default. This function is invoked by the "source" GDB command which
> already has its own path search support. */
> char *abs_filename = NULL;
> - void *result;
> + const void *result;
>
> if (!IS_ABSOLUTE_PATH (filename))
> {
> @@ -452,7 +452,7 @@ gdbscm_safe_source_script (const char *filename)
>
> xfree (abs_filename);
> if (result != NULL)
> - return xstrdup ((char *) result);
> + return xstrdup ((const char *) result);
> return NULL;
> }
> \f
next prev parent reply other threads:[~2015-10-26 5:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 3:49 [PATCH c++ 01/12] Introduce ax_raw_byte and use it Simon Marchi
2015-10-26 4:17 ` [PATCH c++ 03/12] ctf_xfer_partial: Return TARGET_XFER_E_IO instead of -1 on error Simon Marchi
2015-10-27 9:54 ` Simon Marchi
2015-10-26 5:24 ` [PATCH c++ 06/12] Fix constness problem in ioscm_make_gdb_stdio_port Simon Marchi
2015-10-26 12:40 ` Doug Evans
2015-10-26 18:36 ` Pedro Alves
2015-10-27 1:30 ` Simon Marchi
2015-10-27 1:55 ` Pedro Alves
2015-10-27 2:02 ` Doug Evans
2015-10-27 2:07 ` Simon Marchi
2015-10-26 5:27 ` [PATCH c++ 08/12] scm-symbol.c: Add (domain_enum) casts Simon Marchi
2015-10-26 12:55 ` Doug Evans
2015-10-26 5:29 ` [PATCH c++ 05/12] guile: Constify gdbscm_with_guile return value Simon Marchi
2015-10-26 11:45 ` Doug Evans [this message]
2015-10-26 17:39 ` Simon Marchi
2015-10-26 20:34 ` Doug Evans
2015-10-27 9:31 ` Simon Marchi
2015-10-27 17:35 ` Doug Evans
2015-10-28 14:59 ` Simon Marchi
2015-10-26 5:30 ` [PATCH c++ 09/12] stap-probe.c: Add casts Simon Marchi
2015-10-27 9:54 ` Simon Marchi
2015-10-26 5:32 ` [PATCH c++ 10/12] symtab.c: Add cast Simon Marchi
2015-10-26 12:55 ` Doug Evans
2015-10-26 7:53 ` [PATCH c++ 04/12] Add scm_t_dynwind_flags casts Simon Marchi
2015-10-27 14:59 ` Pedro Alves
2015-10-27 16:02 ` Simon Marchi
2015-10-26 8:17 ` [PATCH c++ 07/12] gdbscm_memory_port_write: use local variable to avoid adding casts Simon Marchi
2015-10-26 12:55 ` Doug Evans
2015-10-26 10:03 ` [PATCH c++ 02/12] ctf.c: Fix int/enum implicit cast Simon Marchi
2015-10-27 15:17 ` Pedro Alves
2015-10-27 17:11 ` Yao Qi
2015-10-27 17:14 ` Simon Marchi
2015-10-27 15:08 ` [PATCH c++ 01/12] Introduce ax_raw_byte and use it Pedro Alves
2015-10-27 16:55 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k2qab3v4.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).