From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: kevin.pouget@gmail.com (Kevin Pouget),
gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [RFC] Python Finish Breakpoints
Date: Wed, 04 Jan 2012 16:40:00 -0000 [thread overview]
Message-ID: <m3k457bew3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201201041449.q04EnCCO026716@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Wed, 4 Jan 2012 15:49:12 +0100 (CET)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
Ulrich> The problem is that the finish-breakpoint mechanism sets a breakpoint on
Ulrich> the regular return address of the current frame, i.e. the instruction
Ulrich> where the "call" instruction would return normally. However, when an
Ulrich> exception is thrown and then caught, execution continues at a different
Ulrich> call site (in the catch block). There's now two possibilities:
[...]
I think the test is actually incorrect, and that if it passes, it is
only by accident.
The test assumes that the "finish" will cause the
ExceptionFinishBreakpoint to fire. However, I don't think this
makes sense. A Python "finish" breakpoint will only fire if the
"finish" returns normally; it might fire "accidentally" if the
exception lands at exactly the same spot.
So, I think either result -- a call to the stop method or a call to the
out_of_scope method -- is ok in this situation.
Ulrich> Am I missing some piece of GDB code that attempts to handle this, and
Ulrich> is just malfunctioning? It would certainly be good to properly support
Ulrich> this feature, but until we do, I'd suggest this test case should be
Ulrich> disabled ...
We have support for "finish", and other operations in the presence of
exceptions. Search for _Unwind_DebugHook (in breakpoint.c and infrun.c).
This code only works if you are using a new-enough version of GCC and
have debuginfo for libgcc (but once the stap probe patches are in, you
will no longer need debuginfo).
We could probably augment Python "finish" breakpoints to add a new
method that is called in the exception case.
Tom
next prev parent reply other threads:[~2012-01-04 16:40 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTim+YH64zkWvdz2_kVUUj=AJ7v4LKw@mail.gmail.com>
[not found] ` <BANLkTi=gtHzWzXOJzB+a19=jkfk1hGwQBg@mail.gmail.com>
[not found] ` <BANLkTikVdqbMqjguTV8ct0TWiBDhHGYtLg@mail.gmail.com>
2011-05-11 7:44 ` Kevin Pouget
2011-05-11 10:31 ` Phil Muldoon
2011-05-11 11:29 ` Kevin Pouget
2011-05-12 10:38 ` Kevin Pouget
2011-05-12 10:50 ` Phil Muldoon
2011-05-12 11:29 ` Kevin Pouget
[not found] ` <BANLkTi=Eu-5B4YyhP2rGdQXgXbBN-EmLKA@mail.gmail.com>
[not found] ` <BANLkTikt2hEUcXkGVH44NaUcwiF1SGdMaw@mail.gmail.com>
[not found] ` <BANLkTi=UpgogckTD5MZsW+PC5d2F8X-+jA@mail.gmail.com>
[not found] ` <BANLkTi==bj50mZgFKq_qA-+3-2CQA3tBVw@mail.gmail.com>
[not found] ` <BANLkTimmYEmvKT_984jYEVZnA5RGFpEgNw@mail.gmail.com>
2011-05-19 16:21 ` Tom Tromey
2011-05-24 12:51 ` Kevin Pouget
2011-05-27 20:30 ` Tom Tromey
2011-05-30 9:29 ` Kevin Pouget
2011-10-13 14:34 ` Kevin Pouget
2011-10-20 20:12 ` Tom Tromey
2011-10-20 20:58 ` Tom Tromey
2011-10-21 8:15 ` Kevin Pouget
2011-10-24 11:43 ` Kevin Pouget
2011-10-24 13:20 ` Eli Zaretskii
2011-10-24 14:30 ` Kevin Pouget
2011-10-24 17:14 ` Eli Zaretskii
2011-10-24 15:31 ` Kevin Pouget
2011-10-24 16:27 ` Phil Muldoon
2011-10-25 11:05 ` Kevin Pouget
2011-10-25 11:37 ` Phil Muldoon
2011-10-25 12:22 ` Kevin Pouget
2011-10-28 8:33 ` Kevin Pouget
2011-10-28 20:51 ` Tom Tromey
2011-11-02 14:44 ` Kevin Pouget
2011-11-04 14:25 ` Kevin Pouget
2011-11-04 21:04 ` Tom Tromey
2011-11-09 14:10 ` Kevin Pouget
2011-11-16 10:53 ` Kevin Pouget
2011-11-17 17:49 ` Tom Tromey
2011-11-17 17:48 ` Tom Tromey
[not found] ` <CAPftXUJwtGJhqFyfX6LVK87QH2xeLkvv5kx=yaEnYJMv0YR_rw@mail.gmail.com>
2011-11-24 8:27 ` Kevin Pouget
2011-11-30 16:02 ` Kevin Pouget
2011-12-02 21:49 ` Tom Tromey
2011-12-05 9:29 ` Kevin Pouget
2011-12-06 21:18 ` Tom Tromey
2011-12-07 13:35 ` Kevin Pouget
2011-12-08 15:30 ` Tom Tromey
2011-12-08 16:10 ` Kevin Pouget
2011-12-08 18:08 ` Kevin Pouget
2011-12-09 9:53 ` Kevin Pouget
2011-12-18 19:22 ` Kevin Pouget
2011-12-20 20:55 ` Tom Tromey
2011-12-20 20:58 ` Kevin Pouget
2011-12-21 7:16 ` Joel Brobecker
2011-12-21 17:13 ` Tom Tromey
[not found] ` <CAPftXUKXh9ekZ2kiwQ=5zbrjst+9VH9-eZk8h+Z-9SpQ1WqdLw@mail.gmail.com>
[not found] ` <CAPftXULQFggY3Nz2byC0fMZA1sg4Nymp3hAhe8aSuLNG4cauFg@mail.gmail.com>
[not found] ` <CAPftXUJALHd=-fajVwgowqfCDfXO6JMxSkorWD6CQArsg-PedQ@mail.gmail.com>
[not found] ` <CAPftXULKC8gp3L87+PZEF3dj3crv9bh-uzZpRiYKjqEw_xyptQ@mail.gmail.com>
2011-12-27 4:18 ` Joel Brobecker
2011-12-27 9:40 ` Kevin Pouget
2011-12-27 12:22 ` Joel Brobecker
2011-12-27 9:34 ` Kevin Pouget
2011-12-24 23:56 ` [patch] Fix gdb.python/py-finish-breakpoint.exp new FAIL on x86_64-m32 [Re: [RFC] Python Finish Breakpoints] Jan Kratochvil
2011-12-27 11:13 ` Kevin Pouget
2011-12-27 21:39 ` [commit] " Jan Kratochvil
2012-01-04 17:45 ` Ulrich Weigand
2012-01-04 17:58 ` [commit 7.4] " Jan Kratochvil
2012-01-04 18:10 ` Ulrich Weigand
2011-12-26 11:28 ` [patch] Fix remote.c crash on gdbserver close (+fix py-finish-breakpoint.exp for gdbserver) " Jan Kratochvil
2011-12-27 23:30 ` [patch] Fix remote.c crash on gdbserver close (+fix py-finish-breakpoint.exp for gdbserver) [rediff] Jan Kratochvil
2012-01-02 17:57 ` Tom Tromey
2012-01-02 19:49 ` Pedro Alves
2012-01-19 16:24 ` Call target_close after unpushing, not before (was: Re: [patch] Fix remote.c crash on gdbserver close (+fix py-finish-breakpoint.exp for gdbserver)) Pedro Alves
2012-01-19 16:27 ` Jan Kratochvil
2012-01-19 16:37 ` Call target_close after unpushing, not before Pedro Alves
2012-01-19 16:53 ` [commit] Re: Call target_close after unpushing, not before (was: Re: [patch] Fix remote.c crash on gdbserver close (+fix py-finish-breakpoint.exp for gdbserver)) Jan Kratochvil
2012-01-04 14:49 ` [RFC] Python Finish Breakpoints Ulrich Weigand
2012-01-04 15:24 ` Kevin Pouget
2012-01-04 16:29 ` Ulrich Weigand
2012-01-04 16:42 ` Tom Tromey
2012-01-04 16:40 ` Tom Tromey [this message]
2012-01-04 17:13 ` Ulrich Weigand
2012-01-09 9:21 ` Kevin Pouget
2012-01-27 17:01 ` Kevin Pouget
2011-10-28 19:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k457bew3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).