From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Paul Bolle <pebolle@tiscali.nl>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix uiout for execute_command_to_string
Date: Fri, 10 Sep 2010 22:05:00 -0000 [thread overview]
Message-ID: <m3k4mtl4y8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100909213307.GA32018@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 9 Sep 2010 23:33:07 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Updated the patch with this part. Paul Bolle said he does not have
Jan> a signed FSF copyright assignment; if it matters in this case.
It doesn't, that patch is short enough.
Jan> 2010-09-09 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Paul Bolle <pebolle@tiscali.nl>
One nit.
Jan> +struct cleanup *
Jan> +make_cleanup_ui_out_redirect_pop (struct ui_out *uiout)
Jan> +{
Jan> + return make_my_cleanup (&cleanup_chain, do_ui_out_redirect_pop, uiout);
Jan> +}
The two new functions need header comments.
Ok with that change.
Tom
next prev parent reply other threads:[~2010-09-10 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 20:03 Jan Kratochvil
2010-09-04 15:36 ` Paul Bolle
2010-09-10 13:02 ` Jan Kratochvil
2010-09-10 22:05 ` Tom Tromey [this message]
2010-09-11 18:34 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4mtl4y8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).