From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75539-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24675 invoked by alias); 10 Sep 2010 20:27:37 -0000
Received: (qmail 24665 invoked by uid 22791); 10 Sep 2010 20:27:36 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Sep 2010 20:27:32 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKRUOl025325	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 10 Sep 2010 16:27:30 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKRT6r014149;	Fri, 10 Sep 2010 16:27:30 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKRSiN014461;	Fri, 10 Sep 2010 16:27:28 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 6C9A23792BD; Fri, 10 Sep 2010 14:27:28 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Paul Bolle <pebolle@tiscali.nl>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix uiout for execute_command_to_string
References: <20100903180619.GA15409@host1.dyn.jankratochvil.net>	<1283551592.3230.27.camel@localhost.localdomain>	<20100909213307.GA32018@host1.dyn.jankratochvil.net>
Date: Fri, 10 Sep 2010 22:05:00 -0000
In-Reply-To: <20100909213307.GA32018@host1.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 9 Sep 2010 23:33:07 +0200")
Message-ID: <m3k4mtl4y8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-09/txt/msg00234.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> Updated the patch with this part.  Paul Bolle said he does not have
Jan> a signed FSF copyright assignment; if it matters in this case.

It doesn't, that patch is short enough.

Jan> 2010-09-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	    Paul Bolle  <pebolle@tiscali.nl>

One nit.

Jan> +struct cleanup *
Jan> +make_cleanup_ui_out_redirect_pop (struct ui_out *uiout)
Jan> +{
Jan> +  return make_my_cleanup (&cleanup_chain, do_ui_out_redirect_pop, uiout);
Jan> +}

The two new functions need header comments.
Ok with that change.

Tom