From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125512 invoked by alias); 14 Mar 2017 15:12:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125497 invoked by uid 89); 14 Mar 2017 15:12:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*f:sk:179457d, H*f:sk:m37f3te, H*f:sk:f20365d, H*i:sk:f20365d X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Mar 2017 15:12:41 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2EF8khV058166 for ; Tue, 14 Mar 2017 11:12:40 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 295xm48ndh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 14 Mar 2017 11:12:40 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Mar 2017 15:12:39 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 Mar 2017 15:12:35 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v2EFCY5q19136922; Tue, 14 Mar 2017 15:12:34 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 166F04C044; Tue, 14 Mar 2017 15:12:21 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF61A4C040; Tue, 14 Mar 2017 15:12:20 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.162]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 14 Mar 2017 15:12:20 +0000 (GMT) From: Andreas Arnez To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] inf-ptrace: Do not stop memory transfers after a single word References: <1488816060-20776-1-git-send-email-arnez@linux.vnet.ibm.com> <1488816060-20776-2-git-send-email-arnez@linux.vnet.ibm.com> <06e5cf43-bb8b-6fa5-7201-414dc88388a3@ericsson.com> <5a22f112-9443-b796-9f34-aee112b63625@ericsson.com> <179457d2-c2aa-dd8d-d9c2-e1d3cca93930@redhat.com> Date: Tue, 14 Mar 2017 15:12:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 13 Mar 2017 19:51:47 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17031415-0040-0000-0000-00000342E581 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031415-0041-0000-0000-00002483C024 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-14_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703140119 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00238.txt.bz2 On Mon, Mar 13 2017, Pedro Alves wrote: > On 03/13/2017 07:50 PM, Andreas Arnez wrote: >> On Mon, Mar 13 2017, Pedro Alves wrote: >> >>> On 03/10/2017 03:48 PM, Simon Marchi wrote: >>> >>>> I don't the idea behind that rule. I thought it was just for readability, >>>> to make it clear that the variable is a pointer without having to refer to the >>>> declaration. Perhaps some older timers could shed some light on that :). >>> >>> I don't know the original rationale, but I agree that nowadays the >>> justification can only be in terms of readability. The same reason we >>> do >>> if (integer_that_is_not_a_boolean != 0) >>> instead of >>> if (integer_that_is_not_a_boolean) >>> . >> >> Right, it's a GDB-specific style rule. So who fixes the explanation on >> the Wiki page? :-) > > It's a wiki, so anyone can do that. Want to volunteer? :-) OK, I just changed it and added your example above: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Comparison_With_NULL_And_Zero Comments welcome! -- Andreas