From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32040 invoked by alias); 9 Jan 2012 16:22:31 -0000 Received: (qmail 32020 invoked by uid 22791); 9 Jan 2012 16:22:28 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Jan 2012 16:22:15 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q09GMFSo021343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 9 Jan 2012 11:22:15 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q09GMFiQ006232; Mon, 9 Jan 2012 11:22:15 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q09GMDMT023985; Mon, 9 Jan 2012 11:22:14 -0500 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] Remove wrapper.[ch] References: <4F076E33.1030404@redhat.com> Date: Mon, 09 Jan 2012 16:22:00 -0000 In-Reply-To: <4F076E33.1030404@redhat.com> (Keith Seitz's message of "Fri, 06 Jan 2012 13:57:07 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00273.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> libgdb is history. The introduction of TRY_CATCH is now the standard Keith> way to do these sorts of tasks. There seems little point to support Keith> yet another ancient/nearly unused API to gdb's internals. I agree. This patch is ok. You might want to look at removing gdb_rc entirely. There are only a few more uses; and it seems pointless to me to have a second generic, high-level way to deal with error cases; exceptions are enough for this. (I don't discount the use of having error returns rather than exceptions for specific APIs.) You could then perhaps remove gdb.h as well. Tom