public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] add addrmap iterator
Date: Wed, 06 Oct 2010 16:21:00 -0000	[thread overview]
Message-ID: <m3lj6bqole.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101006044257.CD7C7764B8@ruffy.mtv.corp.google.com> (Doug	Evans's message of "Tue, 5 Oct 2010 21:42:57 -0700 (PDT)")

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I wanted to be able to dump addrmaps so I wrote this patch.

Looks good to me.

Doug> +addrmap_mutable_foreach_worker (splay_tree_node node, void* data)

Wrong spacing in "void *".

Tom

      reply	other threads:[~2010-10-06 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06  4:43 Doug Evans
2010-10-06 16:21 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lj6bqole.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).