From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8278 invoked by alias); 18 Aug 2010 21:59:18 -0000 Received: (qmail 8241 invoked by uid 22791); 18 Aug 2010 21:59:17 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Aug 2010 21:59:12 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7ILxB8l016379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Aug 2010 17:59:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7ILxAsv000709; Wed, 18 Aug 2010 17:59:10 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7ILxAmD029392; Wed, 18 Aug 2010 17:59:10 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D1CF0378196; Wed, 18 Aug 2010 15:59:09 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/3] Template Lookup References: <4C446F49.5070204@redhat.com> Date: Wed, 18 Aug 2010 21:59:00 -0000 In-Reply-To: <4C446F49.5070204@redhat.com> (sami wagiaalla's message of "Mon, 19 Jul 2010 11:29:13 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00318.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> This patch corrects that by introducing a meta variable representing Sami> the template into the scope of the template instance. I think this idea seems reasonable. Sami> +static void Sami> +add_template_variable (struct symbol *symbol, struct pending **listhead, Sami> + struct objfile *objfile) This needs an introductory comment. Sami> + int i; Sami> + Sami> + struct cleanup *all_cleanups = make_cleanup (null_cleanup, NULL); Remove that blank line. Sami> + make_cleanup(xfree, tmp); Space before open paren. There are a few of these. Sami> + /* Has a template symbol for this symbol been added already ? */ Sami> + for (iterator = *(listhead); Sami> + iterator != NULL; Sami> + iterator = iterator->next) I think this means that adding template symbols is O(N^2). A temporary hash table for recording this info would be better. Tom