From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7664 invoked by alias); 22 Jul 2010 16:06:03 -0000 Received: (qmail 7651 invoked by uid 22791); 22 Jul 2010 16:06:02 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Jul 2010 16:05:57 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6MG5s8A027101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Jul 2010 12:05:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6MG5qCY026958; Thu, 22 Jul 2010 12:05:52 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6MG5of9013533; Thu, 22 Jul 2010 12:05:51 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 671263797F3; Thu, 22 Jul 2010 10:05:50 -0600 (MDT) From: Tom Tromey To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [RFA] Fix setting of VSX registers References: <1279738729.11022.23.camel@hactar> Date: Thu, 22 Jul 2010 16:06:00 -0000 In-Reply-To: <1279738729.11022.23.camel@hactar> (Thiago Jung Bauermann's message of "Wed, 21 Jul 2010 15:58:49 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00353.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> The problem is, the function was "fetching" the VSX registers using Thiago> PTRACE_SETVSXREGS instead of PTRACE_GETVSXREGS. Ouch. I don't know this code at all, but this change seems obviously ok to me. Thiago> This patch fixes the typo, and also fixes the vsx-regs.exp testcase to Thiago> use gdb_test instead of send_gdb (this also fixes some synchronization Thiago> issues in the test), and updates the expect info reg output with the new Thiago> v2_double member. I don't understand why the new gdb_test calls have an empty "message" argument. Actually, this code in gdb_test itself looks somewhat bogus. Aside from parsing arguments by hand (why??), it uses a different default for the message than gdb_test_multiple. I don't understand when this can ever be the right thing to do. For your patch I suggest just leaving off the 3rd argument. Also, when the second argument to gdb_test is the empty string ... I suspect you actually want to use gdb_test_no_output. Tom