From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20719 invoked by alias); 2 Jul 2010 19:09:11 -0000 Received: (qmail 20709 invoked by uid 22791); 2 Jul 2010 19:09:11 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Jul 2010 19:09:05 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o62J8tsF012113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Jul 2010 15:08:55 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o62J8siT029527; Fri, 2 Jul 2010 15:08:54 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o62J8r1N001266; Fri, 2 Jul 2010 15:08:53 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 28C4F378196; Fri, 2 Jul 2010 13:08:53 -0600 (MDT) From: Tom Tromey To: "Ulrich Weigand" Cc: pierre.muller@ics-cnrs.unistra.fr (Pierre Muller), gdb-patches@sourceware.org, eliz@gnu.org ('Eli Zaretskii') Subject: Re: [RFA-v3] Allow explicit 16 or 32 char in 'x /s' References: <001201cad75e$2ef3fcc0$8cdbf640$@muller@ics-cnrs.unistra.fr> <201006111737.o5BHbi88031827@d12av02.megacenter.de.ibm.com> Date: Fri, 02 Jul 2010 19:09:00 -0000 In-Reply-To: <201006111737.o5BHbi88031827@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Fri, 11 Jun 2010 19:37:44 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00050.txt.bz2 >>>>> "Ulrich" =3D=3D Ulrich Weigand writes: Ulrich> This test required that malloc is present in the inferior; if target Ulrich> code is statically linked, we need to make sure the routine gets Ulrich> pulled in (just like other testcases already do). Ulrich> * gdb.base/charset.c (main): Make sure malloc gets linked in. With this patch I now get: Running ../../../src/gdb/testsuite/gdb.base/charset.exp ... gdb compile failed, ../../../src/gdb/testsuite/gdb.base/charset.c: In funct= ion =E2=80=98main=E2=80=99: ../../../src/gdb/testsuite/gdb.base/charset.c:126: warning: incompatible im= plicit declaration of built-in function =E2=80=98malloc=E2=80=99 It isn't safe here to include , since this test intentionally defines its own "wchar_t". Adding: extern void *malloc (int); works for me, but it seems possibly problematic. Maybe adding -fno-builtin for gcc is the thing to do? I am not really sure what is best. Any other ideas? Tom