From: Tom Tromey <tromey@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH 1/2] sim: export cb_get_string for people to use
Date: Fri, 27 May 2011 18:24:00 -0000 [thread overview]
Message-ID: <m3mxi8uhmf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1306438878-14479-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Thu, 26 May 2011 15:41:17 -0400")
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> The common sim code provides a useful "get_string" function which reads
Mike> a C string out of the target's memory space. So rename and export it
Mike> for other people to use.
I don't know enough about sim to say whether callback.h is the right
place for this. I would appreciate comments on this.
One nit:
Mike> +int cb_get_string PARAMS ((host_callback *, CB_SYSCALL *, char *, int,
Mike> + unsigned long));
Don't use PARAMS.
Tom
next prev parent reply other threads:[~2011-05-27 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:41 Mike Frysinger
2011-05-26 19:41 ` [PATCH 2/2] sim: bfin: lookup target strings when tracing system calls Mike Frysinger
2011-12-03 19:05 ` Mike Frysinger
2011-05-27 18:24 ` Tom Tromey [this message]
2011-05-27 18:35 ` [PATCH 1/2] sim: export cb_get_string for people to use Mike Frysinger
2011-05-28 14:56 ` [PATCH v2] " Mike Frysinger
2011-12-03 18:40 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxi8uhmf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).