From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31722 invoked by alias); 27 May 2011 18:24:36 -0000 Received: (qmail 31705 invoked by uid 22791); 27 May 2011 18:24:35 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 18:24:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4RIOA0d006438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 May 2011 14:24:10 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4RIOA2R025111; Fri, 27 May 2011 14:24:10 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4RIO9ZX012164; Fri, 27 May 2011 14:24:09 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id DC3283781BA; Fri, 27 May 2011 12:24:08 -0600 (MDT) From: Tom Tromey To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH 1/2] sim: export cb_get_string for people to use References: <1306438878-14479-1-git-send-email-vapier@gentoo.org> Date: Fri, 27 May 2011 18:24:00 -0000 In-Reply-To: <1306438878-14479-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Thu, 26 May 2011 15:41:17 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00649.txt.bz2 >>>>> "Mike" == Mike Frysinger writes: Mike> The common sim code provides a useful "get_string" function which reads Mike> a C string out of the target's memory space. So rename and export it Mike> for other people to use. I don't know enough about sim to say whether callback.h is the right place for this. I would appreciate comments on this. One nit: Mike> +int cb_get_string PARAMS ((host_callback *, CB_SYSCALL *, char *, int, Mike> + unsigned long)); Don't use PARAMS. Tom