From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27727 invoked by alias); 25 Oct 2010 22:41:58 -0000 Received: (qmail 27719 invoked by uid 22791); 25 Oct 2010 22:41:57 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Oct 2010 22:41:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9PMfoCQ027223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 Oct 2010 18:41:51 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9PMfo3t001566; Mon, 25 Oct 2010 18:41:50 -0400 Received: from parfait.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9PMfnDj015938; Mon, 25 Oct 2010 18:41:49 -0400 From: Tom Tromey To: Ken Werner Cc: gdb-patches@sourceware.org Subject: Re: [patch] initial OpenCL C language support References: <201010221920.30046.ken@linux.vnet.ibm.com> Date: Mon, 25 Oct 2010 22:41:00 -0000 In-Reply-To: <201010221920.30046.ken@linux.vnet.ibm.com> (Ken Werner's message of "Fri, 22 Oct 2010 19:20:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00360.txt.bz2 >>>>> "Ken" == Ken Werner writes: Ken> This patch implements initial GDB support for the OpenCL C Ken> Programming Language. Since OpenCL is based on C99 I tried to reuse Ken> GDBs C infrastructure where possible (expression parser, printing Ken> routines, etc). I have been skimming this patch a bit and I think it is very good. I don't have time to fully review it right now, as I'm at the GCC Summit. But I did notice one thing: Ken> +/* Expression evaluator for the OpenCL. Most operations are delegated to Ken> + evaluate_subexp_standard; see that function for a description of the Ken> + arguments. */ Ken> +static struct value * Ken> +evaluate_subexp_opencl (struct type *expect_type, struct expression *exp, Ken> + int *pos, enum noside noside) [...] Ken> + return evaluate_subexp_standard (expect_type, exp, pos, noside); I think this ought to call the C-specific evaluate_subexp_c. You'll need to at least make this non-static, maybe even rename it. I believe that without this some forms of string constants will not work properly. Tom